From dc3fc16ce597dd6c24dc5dd26cf1ae9556c76848 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 29 Sep 2023 12:11:24 -0700 Subject: [PATCH] Remove support for Android API < 23 in ReactTextInputShadowNode (#39686) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39686 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextInputShadowNode changelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextInputShadowNode Reviewed By: NickGerleman Differential Revision: D48545503 fbshipit-source-id: f3b4fb696c3abf1f20ab00a89e786b3787c1b0e9 --- .../views/textinput/ReactTextInputShadowNode.java | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java index 8c123d7545b81b..878da5199174ca 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java @@ -7,8 +7,6 @@ package com.facebook.react.views.textinput; -import android.annotation.TargetApi; -import android.os.Build; import android.text.Layout; import android.util.TypedValue; import android.view.ViewGroup; @@ -35,7 +33,6 @@ import com.facebook.yoga.YogaNode; @VisibleForTesting -@TargetApi(Build.VERSION_CODES.M) public class ReactTextInputShadowNode extends ReactBaseTextShadowNode implements YogaMeasureFunction { @@ -53,10 +50,7 @@ public class ReactTextInputShadowNode extends ReactBaseTextShadowNode public ReactTextInputShadowNode( @Nullable ReactTextViewManagerCallback reactTextViewManagerCallback) { super(reactTextViewManagerCallback); - mTextBreakStrategy = - (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) - ? Layout.BREAK_STRATEGY_SIMPLE - : Layout.BREAK_STRATEGY_HIGH_QUALITY; + mTextBreakStrategy = Layout.BREAK_STRATEGY_HIGH_QUALITY; initMeasureFunction(); } @@ -118,8 +112,7 @@ public long measure( editText.setLines(mNumberOfLines); } - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M - && editText.getBreakStrategy() != mTextBreakStrategy) { + if (editText.getBreakStrategy() != mTextBreakStrategy) { editText.setBreakStrategy(mTextBreakStrategy); } } @@ -182,10 +175,6 @@ public void setPlaceholder(@Nullable String placeholder) { @Override public void setTextBreakStrategy(@Nullable String textBreakStrategy) { - if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) { - return; - } - if (textBreakStrategy == null || "simple".equals(textBreakStrategy)) { mTextBreakStrategy = Layout.BREAK_STRATEGY_SIMPLE; } else if ("highQuality".equals(textBreakStrategy)) {