From 52e54ed8a6cfbf773101cf9b20fe4f8e4afe9c0e Mon Sep 17 00:00:00 2001 From: Dmitry Rykun Date: Mon, 21 Aug 2023 04:24:21 -0700 Subject: [PATCH] Resolve redirects instead of manually downloading nightly Hermes (#38920) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38920 Maven does not provide stable URLs for stored artifacts. Instead there can be a series of redirects for the actual download URL. CocoaPods does not follow redirects when such URL is set as a `source` in a `podspec`. To mitigate that we download Hermes prebuild manually, and that set the `source` to that file. This diff removes this manual download step, and utilizes `curl` to resolve redirects, and then assign final endpoint to `source[:http]` of the `hermes-engine.podspec`. Changelog: [Internal] - Resolve redirects instead of manually downloading nightly Hermes. Reviewed By: cipolleschi Differential Revision: D48225199 fbshipit-source-id: d13f9ef79f7c89c317b854da1170ca8321823d8a --- .../sdks/hermes-engine/hermes-utils.rb | 27 ++++++------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/packages/react-native/sdks/hermes-engine/hermes-utils.rb b/packages/react-native/sdks/hermes-engine/hermes-utils.rb index bec2c4b9897d8a..6c68dd977e446e 100644 --- a/packages/react-native/sdks/hermes-engine/hermes-utils.rb +++ b/packages/react-native/sdks/hermes-engine/hermes-utils.rb @@ -48,7 +48,7 @@ def compute_hermes_source(build_from_source, hermestag_file, git, version, react download_stable_hermes(react_native_path, version, :debug) download_stable_hermes(react_native_path, version, :release) elsif hermes_artifact_exists(nightly_tarball_url(version).gsub("\\", "")) - use_nightly_tarball(source, react_native_path, version) + use_nightly_tarball(source, version) else build_hermes_from_source(source, git) end @@ -80,11 +80,9 @@ def release_tarball_url(version, build_type) return "https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/#{version}/react-native-artifacts-#{version}-hermes-ios-#{build_type.to_s}.tar.gz" end -def use_nightly_tarball(source, react_native_path, version) +def use_nightly_tarball(source, version) putsIfPodPresent('[Hermes] Nightly version, download pre-built for Hermes') - destination_path = download_nightly_hermes(react_native_path, version) - # set tarball as hermes engine - source[:http] = "file://#{destination_path}" + source[:http] = nightly_tarball_url(version) end def putsIfPodPresent(message, level = 'warning') @@ -121,22 +119,9 @@ def download_hermes_tarball(react_native_path, tarball_url, version, configurati return destination_path end -# This function downloads the nightly prebuilt version of Hermes based on the passed version -# and save it in the node_module/react_native/sdks/downloads folder -# It then returns the path to the hermes tarball -# -# Parameters -# - react_native_path: the path to the React Native folder in node modules. It is used as root path to store the Hermes tarball -# - version: the version of React Native that requires the Hermes tarball -# Returns: the path to the downloaded Hermes tarball -def download_nightly_hermes(react_native_path, version) - tarball_url = nightly_tarball_url(version) - return download_hermes_tarball(react_native_path, tarball_url, version, nil) -end - def nightly_tarball_url(version) params = "r=snapshots\&g=com.facebook.react\&a=react-native-artifacts\&c=hermes-ios-debug\&e=tar.gz\&v=#{version}-SNAPSHOT" - return "http://oss.sonatype.org/service/local/artifact/maven/redirect\?#{params}" + return resolve_url_redirects("http://oss.sonatype.org/service/local/artifact/maven/redirect\?#{params}") end def build_hermes_from_source(source, git) @@ -151,6 +136,10 @@ def build_hermes_from_commit(source, git, commit) source[:commit] = commit end +def resolve_url_redirects(url) + return (`curl -Ls -o /dev/null -w %{url_effective} \"#{url}\"`) +end + # This function checks that Hermes artifact exists. # As of now it should check it on the Maven repo. #