From 4e92f609af27505ddfa7b4ec38e88bed6c881d12 Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Tue, 10 Oct 2023 17:43:37 -0700 Subject: [PATCH] rntester Android > Don't call rncore_ModuleProvider(name, params) twice (#40758) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/40758 This is a follow up to https://github.com/facebook/react-native/pull/39987?fbclid=IwAR3qXLYUtfGSg81CpfDZFAwlnOb2J0zcJb1Wpc9ikLtd_9w2FUDovD6Xwx8 As we already call ``` return rncore_ModuleProvider(name, params); ``` in: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55 we don't have to do it again in: https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D50109991 fbshipit-source-id: eeb5af739f4dbf4bf45a21a13eec44ae772db7c4 --- packages/rn-tester/android/app/src/main/jni/OnLoad.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp b/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp index 4866263ab59d9b..c7b717bdda0687 100644 --- a/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp +++ b/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp @@ -14,7 +14,6 @@ #include #include #include -#include namespace facebook { namespace react { @@ -50,7 +49,7 @@ std::shared_ptr javaModuleProvider( if (module != nullptr) { return module; }; - return rncore_ModuleProvider(name, params); + return nullptr; } } // namespace react