From 31850df116fdd1595dddcd7b37a21568e679ffa7 Mon Sep 17 00:00:00 2001 From: James Treanor Date: Wed, 17 Apr 2019 08:32:28 -0700 Subject: [PATCH] Fix nullability warnings in RCTExceptionsManager (#24467) Summary: There are a number of nullability warnings in `RCTExceptionsManager` when building React Native for iOS with Xcode 10.2. This resolves them without changing the existing behavior. See the warnings here: ![image](https://user-images.githubusercontent.com/1773641/56201323-89551380-6038-11e9-9998-b6a8d3d28f36.png) [iOS] [Fixed] - Fix nullability warnings in RCTExceptionsManager Pull Request resolved: https://github.com/facebook/react-native/pull/24467 Differential Revision: D14973485 Pulled By: cpojer fbshipit-source-id: 2fac9f067ac9418397c3913760a2403f9a2cc147 --- React/Modules/RCTExceptionsManager.h | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/React/Modules/RCTExceptionsManager.h b/React/Modules/RCTExceptionsManager.h index 3574bc71b4c3d3..0e4489c57f93ba 100644 --- a/React/Modules/RCTExceptionsManager.h +++ b/React/Modules/RCTExceptionsManager.h @@ -9,13 +9,15 @@ #import +NS_ASSUME_NONNULL_BEGIN + @protocol RCTExceptionsManagerDelegate -- (void)handleSoftJSExceptionWithMessage:(NSString *)message stack:(NSArray *)stack exceptionId:(NSNumber *)exceptionId; -- (void)handleFatalJSExceptionWithMessage:(NSString *)message stack:(NSArray *)stack exceptionId:(NSNumber *)exceptionId; +- (void)handleSoftJSExceptionWithMessage:(nullable NSString *)message stack:(nullable NSArray *)stack exceptionId:(NSNumber *)exceptionId; +- (void)handleFatalJSExceptionWithMessage:(nullable NSString *)message stack:(nullable NSArray *)stack exceptionId:(NSNumber *)exceptionId; @optional -- (void)updateJSExceptionWithMessage:(NSString *)message stack:(NSArray *)stack exceptionId:(NSNumber *)exceptionId; +- (void)updateJSExceptionWithMessage:(nullable NSString *)message stack:(nullable NSArray *)stack exceptionId:(NSNumber *)exceptionId; @end @@ -23,11 +25,13 @@ - (instancetype)initWithDelegate:(id)delegate; -- (void)reportSoftException:(NSString *)message stack:(NSArray *)stack exceptionId:(nonnull NSNumber *)exceptionId; -- (void)reportFatalException:(NSString *)message stack:(NSArray *)stack exceptionId:(nonnull NSNumber *)exceptionId; +- (void)reportSoftException:(nullable NSString *)message stack:(nullable NSArray *)stack exceptionId:(NSNumber *)exceptionId; +- (void)reportFatalException:(nullable NSString *)message stack:(nullable NSArray *)stack exceptionId:(NSNumber *)exceptionId; @property (nonatomic, weak) id delegate; @property (nonatomic, assign) NSUInteger maxReloadAttempts; @end + +NS_ASSUME_NONNULL_END