Skip to content

Commit

Permalink
Fix Shimmer in Fabric Android
Browse files Browse the repository at this point in the history
Summary: ShimmeringView is called: RTShimmeringView Android and ShimmeringView in iOS. This diff adds a mapping into ComponentDescriptorRegistry to temporary enable ShimmeringView component until we can unify names in JS.

Reviewed By: sahrens

Differential Revision: D12991351

fbshipit-source-id: 48e08b8021116221ccfd5f2512c76f65145baa2a
  • Loading branch information
mdvacca authored and facebook-github-bot committed Nov 9, 2018
1 parent 0b31496 commit 28278e1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ static const std::string componentNameByReactViewName(std::string viewName) {
return "ScrollView";
}

if (viewName == "RKShimmeringView") {
return "ShimmeringView";
}

if (viewName == "AndroidProgressBar") {
return "ActivityIndicatorView";
}
Expand Down

0 comments on commit 28278e1

Please sign in to comment.