Update Android profiling instructions #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't get any of this to work last time I tried. I assumed the entire page is completely broken and outdated. Turns out, all of it is still relevant, it's just recommending tools that haven't worked for many years. This changes the recommendation to tools that actually work.
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for this! We're looking to migrate our in-depth tracing markers to be based on perfetto (we've switched to this workflow at Meta) and will look to make this part of the open-source tooling too. |
javache
reviewed
Nov 20, 2024
|
Addressed + added info about method profiling |
|
There's no reason that build should be failing, just tried it locally and it built fine... |
|
Linter is failing with: |
|
Ok, so the strange unrelated infra issue seems to have resolved itself after the last commit. |
|
lmao "it's easy to get confused" is not the meaning of "easy" the linter was designed to prevent :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get any of this to work last time I tried. I assumed the entire page is completely broken and outdated. Turns out, all of it is still relevant, it's just recommending tools that haven't worked for many years. This changes the recommendation to tools that actually work.