Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code example in "Tracking dynamic values" #4361

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

Egor-Kozlov
Copy link
Contributor

@Egor-Kozlov Egor-Kozlov commented Nov 19, 2024

In the docs this code uses useNativeDriver in the wrong position:

image

Instead of

Animated.timing(opacity, {
  toValue: pan.x.interpolate({
    inputRange: [0, 300],
    outputRange: [1, 0],
    useNativeDriver: true,
  }),
}).start();

should be

Animated.timing(opacity, {
  toValue: pan.x.interpolate({
    inputRange: [0, 300],
    outputRange: [1, 0]
  }),
  useNativeDriver: true
}).start();

Here there is a wrong position of useNativeDriver
@facebook-github-bot
Copy link

Hi @Egor-Kozlov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Egor-Kozlov Egor-Kozlov changed the title Fix code example in "Tracking dynamic values" doc: fix code example in "Tracking dynamic values" Nov 19, 2024
@Egor-Kozlov Egor-Kozlov changed the title doc: fix code example in "Tracking dynamic values" docs: fix code example in "Tracking dynamic values" Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 6374a3a
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/673cb70613728e000865f005
😎 Deploy Preview https://deploy-preview-4361--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Egor-Kozlov, nice catch, thank you for the fix and backport! 👍

@Simek
Copy link
Collaborator

Simek commented Nov 19, 2024

@Egor-Kozlov Can you fix the lint issues?

@Egor-Kozlov
Copy link
Contributor Author

@Simek sure

@Simek Simek merged commit 2bb1fa8 into facebook:main Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants