-
Notifications
You must be signed in to change notification settings - Fork 425
Rewrite reportIntrospectionError calls #1898
Comments
What's the best way to submit wiki edits? Once the (code) PR is approved/merged, do you also merge the wiki changes from the fork? |
As far as I understand, the wiki is separate from version control. |
I apologize if I am mistaken, but I can not edit the wiki at all (as I am not part of the organization). That’s why I asked this question. |
If that is the case, things are a bit harder. I suppose if you fork the code base, you can edit the forked wiki and point to it in the PR. Any other suggestions for a good workflow are most welcome. |
Would the following workflow be acceptable? |
We could also host it on the site instead of on the wiki? |
That would (imho) simplify it for everyone in the future. However, I am happy to contribute whichever way suits you the best. |
It probably would make sense to put all of our documentation in a source controlled folder. For now, however, let's stick to the Wiki and let's keep talking about the best way to do this. For example, which GitHub projects are models that we should look to for guidance? |
Once upon a time, Prepack didn't have a real error-handling story besides just throwing an exception.
From this time, there are still a ton of
reportIntrospectionError
calls in the code base.They should all be rewritten, one by one (separate pull-requests, please) into something like the following.
Where PPxxxx should be the next currently unused error code; check
https://github.com/facebook/prepack/wiki/Prepack-diagnostics
for all currently defined error code.
The text was updated successfully, but these errors were encountered: