fix: do not transform internally imported files #9900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Apr 27, 2020
SimenB
force-pushed
the
skip-transforming-internal-requires
branch
from
6acbbee to
d522909
Compare
|
Hah, OOM on circus 🙈 |
|
Does this OOM due to the cache thing? Probably... I can skip it |
SimenB
force-pushed
the
skip-transforming-internal-requires
branch
from
e234611 to
3c87e31
Compare
SimenB
force-pushed
the
skip-transforming-internal-requires
branch
from
3c87e31 to
5cb78d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #9900 +/- ##
==========================================
+ Coverage 64.41% 64.43% +0.02%
==========================================
Files 291 291
Lines 12410 12417 +7
Branches 3059 3062 +3
==========================================
+ Hits 7994 8001 +7
Misses 3770 3770
Partials 646 646
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Any internal module should never be transformed at runtime, so let's just bail early rather than having
ScriptTransformerskip them (or not, which is super wasteful).Test plan
Green CI