Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete flow types from the repo #8061

Merged
merged 5 commits into from
Mar 14, 2019
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 6, 2019

Summary

We have no actual source code using flow anymore (although we have some tests, so the babel preset is kept).

@mjesun @rubennorte I'm not sure if you want to copy over the typings (especially the haste map ones) to RN/Metro?

Test plan

Green CI after removing flow binary and typings

@@ -5,21 +5,22 @@
* LICENSE file in the root directory of this source tree.
*/

import type {TestSchedulerContext} from 'types/TestScheduler';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the only types/ import left in the code base, which is why I converted it to TS

@SimenB
Copy link
Member Author

SimenB commented Mar 6, 2019

image

I like it

@SimenB SimenB merged commit bdeb5af into jestjs:master Mar 14, 2019
@SimenB SimenB deleted the remove-flow branch March 14, 2019 15:02
@thymikee
Copy link
Collaborator

Bye Flow, it was a good ride!

thymikee added a commit to Brantron/jest that referenced this pull request Mar 19, 2019
* upstream/master: (391 commits)
  more precise circus asyncError types (jestjs#8150)
  Add typeahead watch plugin (jestjs#6449)
  fix: getTimerCount not taking immediates and ticks into account (jestjs#8139)
  website: add an additional filter predicate to backers (jestjs#7286)
  [🔥] Revised README (jestjs#8076)
  [jest-each] Fix test function type (jestjs#8145)
  chore: improve bug template labels for easier maintenance (jestjs#8141)
  Add documentation related to auto-mocking (jestjs#8099)
  Add support for bigint to pretty-format (jestjs#8138)
  Revert "Add fuzzing based tests in Jest (jestjs#8012)"
  chore: remove console.log
  chore: Improve description of optional arguments in ExpectAPI.md (jestjs#8126)
  Add fuzzing based tests in Jest (jestjs#8012)
  Move @types/node to the root package.json (jestjs#8129)
  chore: use property initializer syntax (jestjs#8117)
  chore: delete flow types from the repo (jestjs#8061)
  Move changelog entry to the proper version (jestjs#8115)
  Release 24.5.0
  Expose throwOnModuleCollision (jestjs#8113)
  add matchers to expect type (jestjs#8093)
  ...
@danny-does-stuff
Copy link

😢

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants