Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load transformers before installing require hooks #7752

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 29, 2019

Summary

Fixes #7710.

Test plan

I've added an e2e test and tested that this fixes the issue in the reproduction (https://github.com/kentcdodds/jest-transform-self-transform-bug). Not sure how to best add a test? The test has to be that a transformer is not hit by transformIgnorePattern

@kentcdodds
Copy link
Contributor

Fantastic. Thank you @SimenB!

@SimenB

This comment has been minimized.

@SimenB SimenB requested a review from thymikee January 29, 2019 23:11
@SimenB SimenB merged commit b0d7122 into jestjs:master Jan 30, 2019
@SimenB SimenB deleted the preload-transforms branch January 30, 2019 00:26
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants