Babel 7 example readme with warning #7399
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
|
||
| **WARNING** | ||
|
|
||
| If you are using jest version 23 with node version 10 and npm then this repository probably will not work for you. For more information please refer to this [jest issue](https://github.com/facebook/jest/issues/7395) on GitHub. This issue should be fixed in the next major release of jest (v24) when the dependency on babel 6 is dropped. |
There was a problem hiding this comment.
Hmm, npm works for me, it's pnpm that didn't.
|
Nope, both npm and pnpm fail. Tested on Windows 10 and Ubuntu 18.04. That said probably a good idea I add pnpm to the README.md :-) I will update the pull request. |
$ git clone [email protected]:nidkil/jest-issue.git
Cloning into 'jest-issue'...
remote: Enumerating objects: 18, done.
remote: Counting objects: 100% (18/18), done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 18 (delta 3), reused 17 (delta 2), pack-reused 0
Receiving objects: 100% (18/18), 41.70 KiB | 410.00 KiB/s, done.
Resolving deltas: 100% (3/3), done.
$ cd jest-issue
$ node -v
v10.13.0
$ npm -v
6.4.1
$ npm i
> [email protected] install /Users/simen/Development/jest-issue/node_modules/fsevents
> node install
[fsevents] Success: "/Users/simen/Development/jest-issue/node_modules/fsevents/lib/binding/Release/node-v64-darwin-x64/fse.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile
npm notice created a lockfile as package-lock.json. You should commit this file.
added 742 packages from 373 contributors and audited 21316 packages in 19.078s
found 0 vulnerabilities
$ npm t
> [email protected] test /Users/simen/Development/jest-issue
> jest
PASS ./sum.test.js
✓ adds 1 + 2 to equal 3 (4ms)
Test Suites: 1 passed, 1 total
Tests: 1 passed, 1 total
Snapshots: 0 total
Time: 1.386s
Ran all test suites. |
|
nidkil@LOVE-IT c:\dev nidkil@LOVE-IT c:\dev nidkil@LOVE-IT c:\dev\jest-issue nidkil@LOVE-IT c:\dev\jest-issue nidkil@LOVE-IT c:\dev\jest-issue added 674 packages from 353 contributors and audited 21316 packages in 35.169s nidkil@LOVE-IT c:\dev\jest-issue
PASS ./sum.test.js Test Suites: 1 passed, 1 total nidkil@LOVE-IT c:\dev\jest-issue |
|
Seriously, now it is working? WTF? Sometimes this work is enough to drive you insane :-) |
|
Thanks for looking into this @nidkil! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Added README.md with warning about incompatibility between jest, node 10 and npm to example using Babel 7 to avoid users spending time trying to fix a known issue.
Test plan
N/A