Interrupt tests if interactive watch plugin key is pressed #7222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogeliog
commented
Oct 19, 2018
| @@ -321,6 +321,10 @@ export default function watch( | |||
| ).find(plugin => getPluginKey(plugin, globalConfig) === key); | |||
|
|
|||
| if (matchingWatchPlugin != null) { | |||
| if (isRunning) { | |||
There was a problem hiding this comment.
This is something that we are already handling correctly for "non plugin" keys https://github.com/facebook/jest/pull/7222/files#diff-d8a3d0a3a8b42ab87b18835ad8f7cb46R309
SimenB
approved these changes
Oct 20, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression that was introduced here. https://github.com/facebook/jest/pull/5399/files#diff-d8a3d0a3a8b42ab87b18835ad8f7cb46L208
Pressing a key of an interactive watch plugin should interrupt the running tests, otherwise, the output gets messed up.
Test plan
Before
Pressing "p" while tests were running, does not interrupt test run and the output breaks.
After
Pressing "p" while tests were running, interrupts the tests run
