removed useless expect.assertions

[Flavien-Pensato]

In a lot of case expect.assertions(1); is no need. It can be confusing.

In fact, we should never use expect.assertions ^^ expect in some case explained by @rickhanlonii .

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[rickhanlonii]

I think this is intentional, from those same docs:

Make sure to add expect.assertions to verify that a certain number of assertions are called. Otherwise a fulfilled promise would not fail the test

[Flavien-Pensato]

@rickhanlonii exactly ! So why should we use expect.assertions(1); even if we are sure to call expect ?

[rickhanlonii]

So I looked a little closer and this change is great - expect.assertions is not needed when using resolves/rejects 👍

To explain a little better and answer your question - when you're using resolves/rejects, we have built in checking for unexpected behavior. So let's say you have this test:

const fetchData = () => Promise.resolve('foo');

test('the fetch fails with an error', () => {
  return expect(fetchData()).rejects.toMatch('error');
});

Then we show this error:

So we tell you that you're expecting it to reject, but it resolved.

Where you need the expect.assertions is when you do your own promise handling, as in the other examples:

const fetchData = () => Promise.resolve('foo');

test('the fetch fails with an error', () => {
  expect.assertions(1);
  return fetchData().catch(e => {
    expect(e).toMatch('error')
  });
});

Here without the expect.assertions then the promise will resolve and the expectations in the .catch block will not run and the test will pass. Using expect.assertions in this case is basically a replacement for adding a .then block that fails

[rickhanlonii]

LGTM

[rickhanlonii]

This needs a changelog entry and it can go

[rickhanlonii]

Thanks @Flavien-Pensato for your first Jest contribution!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.