-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump package versions #6978
Conversation
885137c
to
d982603
Compare
@@ -13,7 +13,7 @@ exports[`custom transformer instruments files 1`] = ` | |||
"----------|----------|----------|----------|----------|-------------------| | |||
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s | | |||
----------|----------|----------|----------|----------|-------------------| | |||
All files | 0 | 0 | 0 | 0 | | | |||
All files | Unknown | Unknown | Unknown | Unknown | | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@@ -8,10 +8,10 @@ | |||
"license": "MIT", | |||
"main": "build/index.js", | |||
"dependencies": { | |||
"@babel/code-frame": "^7.0.0-beta.35", | |||
"@babel/code-frame": "7.0.0-beta.44", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last version with node 4 support. Upgrading it to 7 stable breaks the browser build... not sure why TBH, didn't dig into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we definitely drop Node 4 support, or do we still secretly support it?
@@ -21,7 +21,6 @@ function createProcessEnv() { | |||
return deepCyclicCopy(process.env); | |||
} | |||
|
|||
// $FlowFixMe: Apparently Flow does not understand that this is a prototype. | |||
const proto: Object = Object.getPrototypeOf(process.env); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to annotate this with Object type or will Flow now infer that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've dropped it, I think? This will just go out in Jest 24 anyways, so no biggie |
Cool, we've supported it for quite a long time after EOL anyway |
2f95001
to
89cc175
Compare
89cc175
to
a277726
Compare
a277726
to
cbd9df0
Compare
Codecov Report
@@ Coverage Diff @@
## master #6978 +/- ##
==========================================
- Coverage 66.93% 66.92% -0.01%
==========================================
Files 250 250
Lines 10405 10405
Branches 4 3 -1
==========================================
- Hits 6965 6964 -1
- Misses 3439 3440 +1
Partials 1 1
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Packages bumped are mostly "drop node 4" or not breaking changes.
Left out Babel stuff (#6949) and jsdom (which requires node 8)
Test plan
Green CI 😀