Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website versions page to links to correct language & delete unused file #6734

Merged
merged 2 commits into from
Jul 22, 2018
Merged

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Jul 22, 2018

Summary

  1. Fix website versions page to links to correct language. This is because current versions page always point to english docs despite being in another language.
    Check https://jestjs.io/ro/versions links and you'll see that documentation links points to /en/

  2. Modify .gitignore & delete i18n/en.json because it will always be auto-generated from Docusaurus. No need to keep it in the repository

  3. Delete publish-gh-pages.js because this is not needed anymore. This is an old remnant file from old Docusaurus version

Extra motivation:
Test netlify deploy preview is now working for new PR

Test plan

Before
before

After
after

@codecov-io
Copy link

Codecov Report

Merging #6734 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6734   +/-   ##
=======================================
  Coverage   63.68%   63.68%           
=======================================
  Files         235      235           
  Lines        9007     9007           
  Branches        4        3    -1     
=======================================
  Hits         5736     5736           
  Misses       3270     3270           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79089db...16d4de3. Read the comment docs.

@thymikee
Copy link
Collaborator

Links are correct now, but I cannot access docs in foreign language on Netlify, e.g. https://deploy-preview-6734--jest-preview.netlify.com/docs/ro/api
It works on prod: https://jestjs.io/docs/en/api

@endiliey
Copy link
Contributor Author

@thymikee
If you try another Jest's PR netlify preview, example: https://deploy-preview-6716--jest-preview.netlify.com/docs/es-ES/getting-started

or even Docusaurus's PR netlify preview
https://deploy-preview-867--docusaurus-preview.netlify.com/docs/zh-CN/installation

It cannot found the docs as well.

This is because for netlify deploy preview, we don't run the whole crowdin-upload, crowdin-download which makes the i18n docs available. Only for production

@thymikee
Copy link
Collaborator

Oh, ok that makes sense. Somehow I missed that!

@thymikee
Copy link
Collaborator

Mind adding a changelog entry? :)

@endiliey
Copy link
Contributor Author

How do you want it to be written ? Kinda unsure on the wordings 😭

@thymikee
Copy link
Collaborator

Use PR title "Fix website versions page to link to correct language", that'll do

@thymikee thymikee merged commit a10bc90 into jestjs:master Jul 22, 2018
@thymikee
Copy link
Collaborator

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants