-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix website versions page to links to correct language & delete unused file #6734
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6734 +/- ##
=======================================
Coverage 63.68% 63.68%
=======================================
Files 235 235
Lines 9007 9007
Branches 4 3 -1
=======================================
Hits 5736 5736
Misses 3270 3270
Partials 1 1 Continue to review full report at Codecov.
|
Links are correct now, but I cannot access docs in foreign language on Netlify, e.g. https://deploy-preview-6734--jest-preview.netlify.com/docs/ro/api |
@thymikee or even Docusaurus's PR netlify preview It cannot found the docs as well. This is because for netlify deploy preview, we don't run the whole crowdin-upload, crowdin-download which makes the i18n docs available. Only for production |
Oh, ok that makes sense. Somehow I missed that! |
Mind adding a changelog entry? :) |
How do you want it to be written ? Kinda unsure on the wordings 😭 |
Use PR title "Fix website versions page to link to correct language", that'll do |
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fix website versions page to links to correct language. This is because current versions page always point to english docs despite being in another language.
Check https://jestjs.io/ro/versions links and you'll see that documentation links points to /en/
Modify
.gitignore
& deletei18n/en.json
because it will always be auto-generated from Docusaurus. No need to keep it in the repositoryDelete
publish-gh-pages.js
because this is not needed anymore. This is an old remnant file from old Docusaurus versionExtra motivation:
Test netlify deploy preview is now working for new PR
Test plan
Before
After