Allow watch plugin to be configured #6603

rogeliog · 2018-07-03T04:03:09Z

Summary

Update docs for watch plugins.

This should make it enable plugins to customize their keys and also allow for custom behavior within plugins, for example, the usage of globs in jest-watch-typeahead

    "watchPlugins": [
      [
        "jest-watch-typeahead/filename",
        {
          "key": "g",
          "prompt": "to filter with a glob",
          "strategy": "glob"
        }
      ],
      [
        "jest-watch-typeahead/filename",
        {
          "key": "k",
          "prompt": "to have a custom prompt"
        }
      ]
    ],

Relates to jest-community/jest-watch-typeahead#9 and jest-community/jest-watch-typeahead#10

I'm not sure if something else needs to be updated in the config parsing. cc: @thymikee

Test plan

SimenB · 2018-07-03T04:07:08Z

Yeeeeees! ❤️

SimenB

Missing docs, other than that, this looks awesome! Love that it's such a small diff

SimenB · 2018-07-03T04:07:58Z

packages/jest-cli/src/__tests__/__snapshots__/watch.test.js.snap

+ › Press p to filter by a filename regex pattern.
+ › Press t to filter by a test name regex pattern.
+ › Press q to quit watch mode.
+ › Press k to configured prompt.


reads weird, but doesn't matter 🙂

Good point, let me change it to Press k to filter with a custom prompt

SimenB · 2018-07-03T04:58:12Z

Single test failing on CI.

rogeliog · 2018-07-03T05:33:32Z

website/versioned_docs/version-23.0/WatchPlugins.md

@@ -148,3 +148,35 @@ class MyWatchPlugin {
  }
 }
 ```
+
+## Customization


@SimenB I added it under the version-23.0 is this OK? Should I add it under a new different version folder instead? Given that it is not present in 23.0

Yeah, it should be in the master docs here: https://github.com/facebook/jest/blob/master/docs/WatchPlugins.md

codecov-io · 2018-07-03T06:20:54Z

Codecov Report

Merging #6603 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6603      +/-   ##
==========================================
- Coverage   63.73%   63.72%   -0.01%     
==========================================
  Files         235      235              
  Lines        8931     8933       +2     
  Branches        4        3       -1     
==========================================
+ Hits         5692     5693       +1     
- Misses       3238     3239       +1     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-config/src/normalize.js	`93.11% <100%> (-0.36%)`	⬇️
packages/jest-cli/src/watch.js	`79.02% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e0a1b...66eecf2. Read the comment docs.

thymikee

👍. Fix docs as already discussed and it's good to go :)

SimenB · 2018-07-03T16:20:10Z

I moved the docs and fixed the linting errors in it

rogeliog · 2018-07-03T16:39:57Z

Thanks!

SimenB · 2018-07-03T16:41:50Z

@rickhanlonii the silent reporter makes out slow tests time out due to no output :P Do you think we could print e.g ping every 8 minutes or something?

SimenB · 2018-07-03T16:42:56Z

@mjesun this is good to go, just timeouts on CI

This Pull Request renovates the package group "jest monorepo". - [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` - [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` # Release Notes <details> <summary>facebook/jest</summary> ### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#2330) [Compare Source](jestjs/jest@v23.2.0...v23.3.0) ##### Features - `[jest-cli]` Allow watch plugin to be configured ([#6603](`https://github.com/facebook/jest/pull/6603`)) - `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#6380](`https://github.com/facebook/jest/pull/6380`)) ##### Fixes - `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#6523](`https://github.com/facebook/jest/pull/6523`)) - `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#6579](`https://github.com/facebook/jest/pull/6579`)) - `[jest-cli]` Fix enter to interrupt watch mode ([#6601](`https://github.com/facebook/jest/pull/6601`)) ##### Chore & Maintenance - `[website]` Switch domain to https://jestjs.io ([#6549](`https://github.com/facebook/jest/pull/6549`)) - `[tests]` Improve stability of `yarn test` on Windows ([#6534](`https://github.com/facebook/jest/pull/6534`)) - `[*]` Transpile object shorthand into Node 4 compatible syntax ([#6582](`https://github.com/facebook/jest/pull/6582`)) - `[*]` Update all legacy links to jestjs.io ([#6622](`https://github.com/facebook/jest/pull/6622`)) - `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#6623](`https://github.com/facebook/jest/pull/6623`)) - `[website]` Only test/deploy website if relevant files are changed ([#6626](`https://github.com/facebook/jest/pull/6626`)) - `[docs]` Describe behavior of `resetModules` option when set to `false` ([#6641](`https://github.com/facebook/jest/pull/6641`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

github-actions · 2021-05-12T12:07:09Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Config watch plugin

1268445

rogeliog requested review from SimenB and thymikee July 3, 2018 04:03

Update changelog

e376065

facebook-github-bot added the cla signed label Jul 3, 2018

SimenB approved these changes Jul 3, 2018

View reviewed changes

Fix test and change snapshot text for custom prompts

b35e820

rogeliog added 2 commits July 2, 2018 21:59

Fix Flow

28267ff

Add docs

66eecf2

rogeliog commented Jul 3, 2018

View reviewed changes

rogeliog mentioned this pull request Jul 3, 2018

Support case insensitive searches jest-community/jest-watch-typeahead#10

Closed

SimenB approved these changes Jul 3, 2018

View reviewed changes

thymikee approved these changes Jul 3, 2018

View reviewed changes

SimenB mentioned this pull request Jul 3, 2018

[jest-editor-support]: jest 23.x compatibility #6586

Merged

SimenB added 2 commits July 3, 2018 18:18

move docs

05997af

fix lint errors in docs

e9197fc

SimenB merged commit de21fd4 into jestjs:master Jul 3, 2018

rogeliog mentioned this pull request Jul 3, 2018

Add support for plugin config jest-community/jest-watch-typeahead#13

Merged

This was referenced Jul 7, 2018

Update jest-environment-jsdom in / from 23.1.0 to 23.3.0 opencomponents/base-templates#320

Closed

Update jest in / from 23.1.0 to 23.3.0 opencomponents/base-templates#321

Merged

rogeliog mentioned this pull request Jul 8, 2018

Feature: broader uses for watch plugins #6473

Merged

dependencies bot mentioned this pull request Jul 9, 2018

Update jest in / from 23.1.0 to 23.3.0 severest/retrobot#161

Closed

This was referenced Aug 1, 2018

Update jest in /modules/api from 22.4.3 to 23.4.2 project-accelerate/accelerate#207

Open

Update jest in /modules/frontend from 22.4.3 to 23.4.2 project-accelerate/accelerate#235

Open

rogeliog mentioned this pull request Sep 20, 2018

Todo items for watch plugins #5478

Closed

7 tasks

dependencies bot mentioned this pull request Nov 1, 2018

Update jest in / from 22.1.4 to 23.6.0 leonardofaria/leozera-ui#250

Closed

snyk-bot mentioned this pull request Mar 17, 2020

[Snyk] Upgrade expect from 23.0.0 to 23.6.0 yowainwright/react-workshop#8

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow watch plugin to be configured #6603

Allow watch plugin to be configured #6603

rogeliog commented Jul 3, 2018 •

edited by SimenB

Loading

SimenB commented Jul 3, 2018

SimenB left a comment

SimenB Jul 3, 2018

rogeliog Jul 3, 2018

SimenB commented Jul 3, 2018

rogeliog Jul 3, 2018

SimenB Jul 3, 2018

codecov-io commented Jul 3, 2018

thymikee left a comment

SimenB commented Jul 3, 2018 •

edited

Loading

rogeliog commented Jul 3, 2018

SimenB commented Jul 3, 2018 •

edited

Loading

SimenB commented Jul 3, 2018

github-actions bot commented May 12, 2021

Allow watch plugin to be configured #6603

Allow watch plugin to be configured #6603

Conversation

rogeliog commented Jul 3, 2018 • edited by SimenB Loading

Summary

Test plan

SimenB commented Jul 3, 2018

SimenB left a comment

Choose a reason for hiding this comment

SimenB Jul 3, 2018

Choose a reason for hiding this comment

rogeliog Jul 3, 2018

Choose a reason for hiding this comment

SimenB commented Jul 3, 2018

rogeliog Jul 3, 2018

Choose a reason for hiding this comment

SimenB Jul 3, 2018

Choose a reason for hiding this comment

codecov-io commented Jul 3, 2018

Codecov Report

thymikee left a comment

Choose a reason for hiding this comment

SimenB commented Jul 3, 2018 • edited Loading

rogeliog commented Jul 3, 2018

SimenB commented Jul 3, 2018 • edited Loading

SimenB commented Jul 3, 2018

github-actions bot commented May 12, 2021

rogeliog commented Jul 3, 2018 •

edited by SimenB

Loading

SimenB commented Jul 3, 2018 •

edited

Loading

SimenB commented Jul 3, 2018 •

edited

Loading