Adding xit and fit to the test result locations

[svenliebig]

This command did return the location with null in the json restults for xit and fit nodes.

node <pathToMyProject>\node_modules\jest\bin\jest -c=<pathToMyProject>\package.json ./test/myTest.test.jsx --json --testLocationInResults

After the code changes the test location of xit and fit results are present.

Fixes #6453

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[codecov-io]

Codecov Report

Merging #6482 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6482      +/-   ##
==========================================
- Coverage   66.65%   66.57%   -0.08%     
==========================================
  Files         253      253              
  Lines       10621    10633      +12     
  Branches        4        3       -1     
==========================================
  Hits         7079     7079              
- Misses       3541     3553      +12     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-jasmine2/src/index.js	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ba3e6...b94a41e. Read the comment docs.

[thymikee]

Mind updating a test for it in e2e/__tests__/location_in_results.test.js?

[svenliebig]

Yes, didn't found the related test package, thanks! I will update them

[svenliebig]

I dont know why the ci is failing at this tests, tried a "beforeEach" in line 74, or do it inline like it was before, still failing. Locally the tests are running with the equal command that circleci is using:
node ./packages/jest-cli/bin/jest.js ./e2e/__tests__/location_in_results.test.js -i --testResultsProcessor=jest-junit

@thymikee @SimenB would need some help here, tried several things and have no clue what is happening

(Left my comments to show my previous approach in the location_in_results.test.js)

[SimenB]

Hey! Sorry about the super slow response! 😱

To run with circus, do JEST_CIRCUS=1 ./jest location_in_results. That should show you the error.

The thing is that you also need to add support for this in jest-circus: https://github.com/facebook/jest/tree/master/packages/jest-circus.

This also needs a rebase 🙂

[SimenB]

@Sly321 ping 🙂

[SimenB]

@Sly321 any chance of updating this so we can land it?

[svenliebig]

Sorry i am very busy at the moment with my work and vacation preparations, but if travis is now joining the circle ci results, this should be finally done.

[SimenB]

Ah, circus just worked out of the box now, that's awesome.

Thanks for fixing this!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.