Add error throwing to 'it'/'test' for incorrect arguments. #5558

brianlmacdonald · 2018-02-14T01:09:23Z

Summary

Addresses #5493. Previously, missing or invalid arguments in 'it' and 'test' would cause the tests to be skipped. This PR adds error throwing in both jest-jasmine2 and jest-circus, ensuring that when passing arguments:

The first argument is a string.
There is a second argument.
That the second argument is a function.

Test plan

const {sum} = require('./sums.js')
//correct
it('adds', ()  => {
  expect(sum(2, 3)).toBe(5)
})
//incorrect
// first argument must be a string!
it(() => {
  expect(sum(2, 3,)).toBe(5)
})
//missing second argument!
it('adds')
//second argument must be a function!
it('adds', 'not a function')

I linked the development build of the feature branch to another project and ran tests there to make sure it passed external tests, as well as the internal tests.

It works correctly with valid arguments.

It throws these magnificent errors with invalid arguments.

For the internal tests, jest-jasmine2, would throw an error for the correct use cases, because of its rule about nested tests. Go figure, testing tests is tricky.

I test jest-circus's 'it' with jest-jasmine2's 'it'. I needed to differentiate between the two methods, but since the jest-circus methods are module.exports I couldn't use imports' 'as' keyword to alias jest-circus's 'it', so i made an alias maker function, requiring in jest-circus's it and renaming it circusIt.

Also, had to add jest-circus's test file to the flowconfig ignore otherwise it wouldn't allow for invalid arguments. Flow, you are too good sometimes!

Note: the /integration-tests/tests/globals.test.js has two tests expecting an unimplemented test/it to return a status 0, which it can't anymore because of the nature of this feature. To get this up to speed I changed the names of these tests to start with "cannot test...", changed the expected status to 1, and since part of these tests requires the ``rest` snapshot, which lists the absolute path to the file starting with the root of my computer, I cleaned up the path in Utils, removing the non-universal parts of the path.

codecov-io · 2018-02-14T01:19:20Z

Codecov Report

Merging #5558 into master will increase coverage by 0.8%.
The diff coverage is 62.5%.

@@            Coverage Diff            @@
##           master    #5558     +/-   ##
=========================================
+ Coverage   62.35%   63.15%   +0.8%     
=========================================
  Files         216      216             
  Lines        7908     7912      +4     
  Branches        4        3      -1     
=========================================
+ Hits         4931     4997     +66     
+ Misses       2976     2914     -62     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-jasmine2/src/jasmine/Env.js	`0% <0%> (ø)`	⬆️
packages/jest-message-util/src/index.js	`81.1% <100%> (ø)`	⬆️
packages/jest-circus/src/index.js	`70% <100%> (+70%)`	⬆️
...kages/jest-circus/src/format_node_assert_errors.js	`19.44% <0%> (+19.44%)`	⬆️
packages/jest-circus/src/utils.js	`19.76% <0%> (+19.76%)`	⬆️
packages/jest-circus/src/event_handler.js	`23.07% <0%> (+23.07%)`	⬆️
packages/jest-circus/src/state.js	`92.3% <0%> (+92.3%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196d9b8...f3f1213. Read the comment docs.

SimenB · 2018-02-14T09:35:33Z

packages/jest-circus/src/index.js

+      `Invalid first argument, ${testName}. It must be a string.`,
+    );
+  }
+  if (fn === undefined) {


It is legal to not pass second argument, I use it as test placeholders.

Might be a a good idea to have an explicit test.todo for that case, though

SimenB · 2018-02-14T09:35:58Z

packages/jest-jasmine2/src/jasmine/Env.js

+          `Invalid first argument, ${description}. It must be a string.`,
+        );
+      }
+      if (fn === undefined) {


Ok, cool. So to clarify: add an it.todo and test.todo to ignore cases like

test.todo('justOneArgument')

but still throw the error for test('justOneArgument')?

I think "yes", but it's too breaking. But I think we should do it for the next version.

(I'm all for adding test/it.todo now - though probably in a separate PR)

@cpojer thoughts?

I'm not sure about test.todo, let's discuss that separately. I'm definitely on board with making test/it with one argument throw. I do not consider it a breaking change but rather a bug fix, so it's fine to go into a minor.

fair enough 🙂

SimenB · 2018-02-14T20:28:56Z

integration-tests/__tests__/globals.test.js


  const {summary, rest} = extractSummary(stderr);
-  expect(rest).toMatchSnapshot();
+  // expect(rest).toMatchSnapshot();


why are these commented out?

I think this PR is pretty good to go other than that 🙂

Ok, great. Let me make those changes and I'll push it up.

@SimenB , that snapshot was commented out because it listed the absolute path to the file on my computer, which won't match when the CI is run. Any ideas on how to hide the path?

Your path is messed up - it's a relative path to an absolute one...

invalid

SimenB · 2018-02-15T16:43:56Z

integration-tests/__tests__/globals.test.js


  const {summary, rest} = extractSummary(stderr);
-  expect(rest).toMatchSnapshot();
+  const restWithoutStack = rest.slice(0, 343);


Heh, seems somewhat arbitrary.

We should probably clean the stack up better instead of adding this hack

Should I use formatStackTrace from jest-message-utils when creating the error?

No, it's called automatically.

As it's only an issue for the integration tests (as they used linked files instead of inside node_module), I think we should be good with just stripping that single line in https://github.com/facebook/jest/blob/d065e87a2322e1b4b70e7ba9de3c24aed7a2ea72/integration-tests/Utils.js#L162

@SimenB I'm struggling with this one bit. cleanupStackTrace doesn't replace the stacktrace for the Env, but does for everything else.

thymikee · 2018-02-15T20:45:30Z

integration-tests/__tests__/__snapshots__/globals.test.js.snap

+
+      431 |       }
+      432 |       if (fn === undefined) {
+    > 433 |         throw new Error(


Ugh, any way we can disable code frame for this one, @SimenB?

It points to the it in real code, not sure why it shows the throw here..

the frame is probably unable to find __tests__/only-constructs.test.js for whatever reason - I'd debug that

Ok, I’ll look in it. Thanks!

It was pulling in the wrong frame because In jest-message-util

for (const line of lines) { if ( line.includes(PATH_NODE_MODULES) || line.includes(PATH_EXPECT_BUILD) ) { continue; }

Wouldn't catch if the the top frame was from jest packages, so I added a condition:

const PATH_JEST_PACKAGES = `${path.sep}jest${path.sep}packages${path.sep}`;

that way it ignores the jest code as the topframe.

This Pull Request updates dependency [jest](https://github.com/facebook/jest) from `v22.4.3` to `v23.0.1` <details> <summary>Release Notes</summary> ### [`v23.0.1`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#2301) [Compare Source](jestjs/jest@v23.0.0...3a3b4e3) ##### Chore & Maintenance * `[jest-jasemine2]` Add dependency on jest-each ([#6308](`https://github.com/facebook/jest/pull/6308`)) * `[jest-each]` Move jest-each into core Jest ([#6278](`https://github.com/facebook/jest/pull/6278`)) * `[examples]` Update typescript example to using ts-jest ([#6260](`https://github.com/facebook/jest/pull/6260`)) ##### Fixes * `[pretty-format]` Serialize inverse asymmetric matchers correctly ([#6272](`https://github.com/facebook/jest/pull/6272`)) --- ### [`v23.0.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#2300) [Compare Source](jestjs/jest@2745e3e...v23.0.0) ##### Features * `[expect]` Expose `getObjectSubset`, `iterableEquality`, and `subsetEquality` ([#6210](`https://github.com/facebook/jest/pull/6210`)) * `[jest-snapshot]` Add snapshot property matchers ([#6210](`https://github.com/facebook/jest/pull/6210`)) * `[jest-config]` Support jest-preset.js files within Node modules ([#6185](`https://github.com/facebook/jest/pull/6185`)) * `[jest-cli]` Add `--detectOpenHandles` flag which enables Jest to potentially track down handles keeping it open after tests are complete. ([#6130](`https://github.com/facebook/jest/pull/6130`)) * `[jest-jasmine2]` Add data driven testing based on `jest-each` ([#6102](`https://github.com/facebook/jest/pull/6102`)) * `[jest-matcher-utils]` Change "suggest to equal" message to be more advisory ([#6103](`https://github.com/facebook/jest/issues/6103`)) * `[jest-message-util]` Don't ignore messages with `vendor` anymore ([#6117](`https://github.com/facebook/jest/pull/6117`)) * `[jest-validate]` Get rid of `jest-config` dependency ([#6067](`https://github.com/facebook/jest/pull/6067`)) * `[jest-validate]` Adds option to inject `deprecationEntries` ([#6067](`https://github.com/facebook/jest/pull/6067`)) * `[jest-snapshot]` [**BREAKING**] Concatenate name of test, optional snapshot name and count ([#6015](`https://github.com/facebook/jest/pull/6015`)) * `[jest-runtime]` Allow for transform plugins to skip the definition process method if createTransformer method was defined. ([#5999](`https://github.com/facebook/jest/pull/5999`)) * `[expect]` Add stack trace for async errors ([#6008](`https://github.com/facebook/jest/pull/6008`)) * `[jest-jasmine2]` Add stack trace for timeouts ([#6008](`https://github.com/facebook/jest/pull/6008`)) * `[jest-jasmine2]` Add stack trace for thrown non-`Error`s ([#6008](`https://github.com/facebook/jest/pull/6008`)) * `[jest-runtime]` Prevent modules from marking themselves as their own parent ([#5235](`https://github.com/facebook/jest/issues/5235`)) * `[jest-mock]` Add support for auto-mocking generator functions ([#5983](`https://github.com/facebook/jest/pull/5983`)) * `[expect]` Add support for async matchers ([#5919](`https://github.com/facebook/jest/pull/5919`)) * `[expect]` Suggest toContainEqual ([#5948](`https://github.com/facebook/jest/pull/5953`)) * `[jest-config]` Export Jest's default options ([#5948](`https://github.com/facebook/jest/pull/5948`)) * `[jest-editor-support]` Move `coverage` to `ProjectWorkspace.collectCoverage` ([#5929](`https://github.com/facebook/jest/pull/5929`)) * `[jest-editor-support]` Add `coverage` option to runner ([#5836](`https://github.com/facebook/jest/pull/5836`)) * `[jest-haste-map]` Support extracting dynamic `import`s ([#5883](`https://github.com/facebook/jest/pull/5883`)) * `[expect]` Improve output format for mismatchedArgs in mock/spy calls. ([#5846](`https://github.com/facebook/jest/pull/5846`)) * `[jest-cli]` Add support for using `--coverage` in combination with watch mode, `--onlyChanged`, `--findRelatedTests` and more ([#5601](`https://github.com/facebook/jest/pull/5601`)) * `[jest-jasmine2]` [**BREAKING**] Adds error throwing and descriptive errors to `it`/ `test` for invalid arguments. `[jest-circus]` Adds error throwing and descriptive errors to `it`/ `test` for invalid arguments ([#5558](`https://github.com/facebook/jest/pull/5558`)) * `[jest-matcher-utils]` Add `isNot` option to `matcherHint` function ([#5512](`https://github.com/facebook/jest/pull/5512`)) * `[jest-config]` Add `<rootDir>` to runtime files not found error report ([#5693](`https://github.com/facebook/jest/pull/5693`)) * `[expect]` Make toThrow matcher pass only if Error object is returned from promises ([#5670](`https://github.com/facebook/jest/pull/5670`)) * `[expect]` Add isError to utils ([#5670](`https://github.com/facebook/jest/pull/5670`)) * `[expect]` Add inverse matchers (`expect.not.arrayContaining`, etc., [#5517](`https://github.com/facebook/jest/pull/5517`)) * `[expect]` `expect.extend` now also extends asymmetric matchers ([#5503](`https://github.com/facebook/jest/pull/5503`)) * `[jest-mock]` Update `spyOnProperty` to support spying on the prototype chain ([#5753](`https://github.com/facebook/jest/pull/5753`)) * `[jest-mock]` Add tracking of return values in the `mock` property ([#5752](`https://github.com/facebook/jest/pull/5752`)) * `[jest-mock]` Add tracking of thrown errors in the `mock` property ([#5764](`https://github.com/facebook/jest/pull/5764`)) * `[expect]`Add nthCalledWith spy matcher ([#5605](`https://github.com/facebook/jest/pull/5605`)) * `[jest-cli]` Add `isSerial` property that runners can expose to specify that they can not run in parallel ([#5706](`https://github.com/facebook/jest/pull/5706`)) * `[expect]` Add `.toBeCalledTimes` and `toHaveBeenNthCalledWith` aliases ([#5826](`https://github.com/facebook/jest/pull/5826`)) * `[jest-cli]` Interactive Snapshot Mode improvements ([#5864](`https://github.com/facebook/jest/pull/5864`)) * `[jest-editor-support]` Add `no-color` option to runner ([#5909](`https://github.com/facebook/jest/pull/5909`)) * `[jest-jasmine2]` Pretty-print non-Error object errors ([#5980](`https://github.com/facebook/jest/pull/5980`)) * `[jest-message-util]` Include column in stack frames ([#5889](`https://github.com/facebook/jest/pull/5889`)) * `[expect]` Introduce toStrictEqual ([#6032](`https://github.com/facebook/jest/pull/6032`)) * `[expect]` Add return matchers ([#5879](`https://github.com/facebook/jest/pull/5879`)) * `[jest-cli]` Improve snapshot summaries ([#6181](`https://github.com/facebook/jest/pull/6181`)) * `[expect]` Include custom mock names in error messages ([#6199](`https://github.com/facebook/jest/pull/6199`)) * `[jest-diff]` Support returning diff from oneline strings ([#6221](`https://github.com/facebook/jest/pull/6221`)) * `[expect]` Improve return matchers ([#6172](`https://github.com/facebook/jest/pull/6172`)) * `[jest-cli]` Overhaul watch plugin hooks names ([#6249](`https://github.com/facebook/jest/pull/6249`)) * `[jest-mock]` Include tracked call results in serialized mock ([#6244](`https://github.com/facebook/jest/pull/6244`)) ##### Fixes * `[jest-cli]` Fix stdin encoding to utf8 for watch plugins. ([#6253](`https://github.com/facebook/jest/issues/6253`)) * `[expect]` Better detection of DOM Nodes for equality ([#6246](`https://github.com/facebook/jest/pull/6246`)) * `[jest-cli]` Fix misleading action description for F key when in "only failed tests" mode. ([#6167](`https://github.com/facebook/jest/issues/6167`)) * `[jest-worker]` Stick calls to workers before processing them ([#6073](`https://github.com/facebook/jest/pull/6073`)) * `[babel-plugin-jest-hoist]` Allow using `console` global variable ([#6075](`https://github.com/facebook/jest/pull/6075`)) * `[jest-jasmine2]` Always remove node core message from assert stack traces ([#6055](`https://github.com/facebook/jest/pull/6055`)) * `[expect]` Add stack trace when `expect.assertions` and `expect.hasAssertions` causes test failures. ([#5997](`https://github.com/facebook/jest/pull/5997`)) * `[jest-runtime]` Throw a more useful error when trying to require modules after the test environment is torn down ([#5888](`https://github.com/facebook/jest/pull/5888`)) * `[jest-mock]` [**BREAKING**] Replace timestamps with `invocationCallOrder` ([#5867](`https://github.com/facebook/jest/pull/5867`)) * `[jest-jasmine2]` Install `sourcemap-support` into normal runtime to catch runtime errors ([#5945](`https://github.com/facebook/jest/pull/5945`)) * `[jest-jasmine2]` Added assertion error handling inside `afterAll hook` ([#5884](`https://github.com/facebook/jest/pull/5884`)) * `[jest-cli]` Remove the notifier actions in case of failure when not in watch mode. ([#5861](`https://github.com/facebook/jest/pull/5861`)) * `[jest-mock]` Extend .toHaveBeenCalled return message with outcome ([#5951](`https://github.com/facebook/jest/pull/5951`)) * `[jest-runner]` Assign `process.env.JEST_WORKER_ID="1"` when in runInBand mode ([#5860](`https://github.com/facebook/jest/pull/5860`)) * `[jest-cli]` Add descriptive error message when trying to use `globalSetup`/`globalTeardown` file that doesn't export a function. ([#5835](`https://github.com/facebook/jest/pull/5835`)) * `[expect]` Do not rely on `instanceof RegExp`, since it will not work for RegExps created inside of a different VM ([#5729](`https://github.com/facebook/jest/pull/5729`)) * `[jest-resolve]` Update node module resolution algorithm to correctly handle symlinked paths ([#5085](`https://github.com/facebook/jest/pull/5085`)) * `[jest-editor-support]` Update `Settings` to use spawn in shell option ([#5658](`https://github.com/facebook/jest/pull/5658`)) * `[jest-cli]` Improve the error message when 2 projects resolve to the same config ([#5674](`https://github.com/facebook/jest/pull/5674`)) * `[jest-runtime]` remove retainLines from coverage instrumentation ([#5692](`https://github.com/facebook/jest/pull/5692`)) * `[jest-cli]` Fix update snapshot issue when using watchAll ([#5696](`https://github.com/facebook/jest/pull/5696`)) * `[expect]` Fix rejects.not matcher ([#5670](`https://github.com/facebook/jest/pull/5670`)) * `[jest-runtime]` Prevent Babel warnings on large files ([#5702](`https://github.com/facebook/jest/pull/5702`)) * `[jest-mock]` Prevent `mockRejectedValue` from causing unhandled rejection ([#5720](`https://github.com/facebook/jest/pull/5720`)) * `[pretty-format]` Handle React fragments better ([#5816](`https://github.com/facebook/jest/pull/5816`)) * `[pretty-format]` Handle formatting of `React.forwardRef` and `Context` components ([#6093](`https://github.com/facebook/jest/pull/6093`)) * `[jest-cli]` Switch collectCoverageFrom back to a string ([#5914](`https://github.com/facebook/jest/pull/5914`)) * `[jest-regex-util]` Fix handling regex symbols in tests path on Windows ([#5941](`https://github.com/facebook/jest/pull/5941`)) * `[jest-util]` Fix handling of NaN/Infinity in mock timer delay ([#5966](`https://github.com/facebook/jest/pull/5966`)) * `[jest-resolve]` Generalise test for package main entries equivalent to ".". ([#5968](`https://github.com/facebook/jest/pull/5968`)) * `[jest-config]` Ensure that custom resolvers are used when resolving the configuration ([#5976](`https://github.com/facebook/jest/pull/5976`)) * `[website]` Fix website docs ([#5853](`https://github.com/facebook/jest/pull/5853`)) * `[expect]` Fix isEqual Set and Map to compare object values and keys regardless of order ([#6150](`https://github.com/facebook/jest/pull/6150`)) * `[pretty-format]` [**BREAKING**] Remove undefined props from React elements ([#6162](`https://github.com/facebook/jest/pull/6162`)) * `[jest-haste-map]` Properly resolve mocked node modules without package.json defined ([#6232](`https://github.com/facebook/jest/pull/6232`)) ##### Chore & Maintenance * `[jest-runner]` Move sourcemap installation from `jest-jasmine2` to `jest-runner` ([#6176](`https://github.com/facebook/jest/pull/6176`)) * `[jest-cli]` Use yargs's built-in `version` instead of rolling our own ([#6215](`https://github.com/facebook/jest/pull/6215`)) * `[docs]` Add explanation on how to mock methods not implemented in JSDOM * `[jest-jasmine2]` Simplify `Env.execute` and TreeProcessor to setup and clean resources for the top suite the same way as for all of the children suites ([#5885](`https://github.com/facebook/jest/pull/5885`)) * `[babel-jest]` [**BREAKING**] Always return object from transformer ([#5991](`https://github.com/facebook/jest/pull/5991`)) * `[*]` Run Prettier on compiled output ([#5858](`https://github.com/facebook/jest/pull/3497`)) * `[jest-cli]` Add fileChange hook for plugins ([#5708](`https://github.com/facebook/jest/pull/5708`)) * `[docs]` Add docs on using `jest.mock(...)` ([#5648](`https://github.com/facebook/jest/pull/5648`)) * `[docs]` Mention Jest Puppeteer Preset ([#5722](`https://github.com/facebook/jest/pull/5722`)) * `[docs]` Add jest-community section to website ([#5675](`https://github.com/facebook/jest/pull/5675`)) * `[docs]` Add versioned docs for v22.4 ([#5733](`https://github.com/facebook/jest/pull/5733`)) * `[docs]` Improve Snapshot Testing Guide ([#5812](`https://github.com/facebook/jest/issues/5812`)) * `[jest-runtime]` [**BREAKING**] Remove `jest.genMockFn` and `jest.genMockFunction` ([#6173](`https://github.com/facebook/jest/pull/6173`)) * `[jest-message-util]` Avoid adding unnecessary indent to blank lines in stack traces ([#6211](`https://github.com/facebook/jest/pull/6211`)) --- ### [`v22.4.4`](jestjs/jest@6851d8b...v22.4.4) [Compare Source](jestjs/jest@6851d8b...v22.4.4) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

shellscape · 2018-05-30T23:54:08Z

Did anyone realize that this broke the intent behind #1775? Even test.skip now produces this error. It seems awfully needless that an intentionally skipped test (as there doesn't appear to be a test.todo equivalent) requires a noop function to pass validation.

… tests Ref: jestjs/jest#5558

elyobo · 2018-06-13T06:11:29Z

@evocateur yeah, it should really be called out as breaking in the changelog. Just updated it: 02f4166

Why not implement it in a non-breaking way instead? #5493 doesn't require checking the second argument, only the first.

- Continues to validate arguments to avoid accidental skips from jestjs#5558

updated `jest` and `babel-jest` to `v23` fixed breaking change in `jest`: - https://github.com/facebook/jest/blob/master/CHANGELOG.md#2300 - jestjs/jest#5558 _edit:_ forgot to mention. test runner fix is based on: https://github.com/babel/babel/blob/master/packages/babel-parser/test/helpers/runFixtureTests.js#L11

github-actions · 2021-05-12T13:14:38Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

brianlmacdonald added 15 commits February 12, 2018 12:45

feat: adds error when using it or test without proper arguments

6e41bcd

fix: adds more descriptive error message

b551940

feat: adds tests for errors

1de43af

fix: removes bad test

f4a012e

feat: adds tests for circus and jasmine2

a84007f

fix: small tweaks to test names

85587bd

fix: adds circus test to flow ignore

325fe11

fix: variable names for circus it

363e590

chore: updates changelog.

bf07249

fixes: lint error

918ad6d

updates: globals tests and snapshots

d2a3668

fix: resets snapshot file

b489b37

fix: temp skips failing tests until further direction

a873a75

feat: adds tests for test alias

119130c

fix: renamed unimplemented test. Comments out rest snapshot for now.

1d6e12c

facebook-github-bot added the CLA Signed ✔️ label Feb 14, 2018

SimenB previously requested changes Feb 14, 2018

View reviewed changes

SimenB reviewed Feb 14, 2018

View reviewed changes

fix: restores rest snapshot and removes abs path from snapshot stack

29a0f0a

SimenB reviewed Feb 15, 2018

View reviewed changes

brianlmacdonald added 6 commits February 15, 2018 13:02

fix: cleans up stack using cleanUpStackTrace

d8eac51

fix: modifies regex in utils

e09303f

fix: reverts utils regex

5106800

fix: reverts line deletion in utils.

84d9a9b

fix: replaces env in cleanup stack trace

7815602

fix: updates utils to current version

0728d30

thymikee reviewed Feb 15, 2018

View reviewed changes

fix: updates master

b10ad04

thymikee mentioned this pull request May 29, 2018

Add Jest 23 Blog Post #6332

Merged

dependencies bot mentioned this pull request Jun 1, 2018

Update babel-jest in / from 22.1.0 to 23.0.1 leonardofaria/leozera-ui#192

Closed

MrOrz added a commit to cofacts/rumors-line-bot that referenced this pull request Jun 9, 2018

Implement missing tests because jest 23 no longer skips unimplemented…

59145e1

… tests Ref: jestjs/jest#5558

javorosas mentioned this pull request Jun 10, 2018

Excluding second argument should not throw, but instead mark the test as skipped #6430

Closed

louh mentioned this pull request Jun 21, 2018

Bump all dependencies streetmix/streetmix#1061

Merged

pk-nb added a commit to pk-nb/jest that referenced this pull request Jul 2, 2018

Reallowed single string arguments for pending tests

91d90c8

- Continues to validate arguments to avoid accidental skips from jestjs#5558

pk-nb added a commit to pk-nb/jest that referenced this pull request Jul 2, 2018

Reallowed single string arguments for pending tests

f84e19c

- Continues to validate arguments to avoid accidental skips from jestjs#5558

pk-nb mentioned this pull request Jul 2, 2018

Re-allowed single string arguments for pending tests #6602

Closed

pk-nb added a commit to pk-nb/jest that referenced this pull request Jul 2, 2018

Reallowed single string arguments for pending tests

922686d

- Continues to validate arguments to avoid accidental skips from jestjs#5558

pk-nb added a commit to pk-nb/jest that referenced this pull request Jul 12, 2018

Reallowed single string arguments for pending tests

91e83e2

- Continues to validate arguments to avoid accidental skips from jestjs#5558

dnalborczyk mentioned this pull request Jul 19, 2018

update jest (major), babel-jest (major) babel/babel#8341

Merged

dependencies bot mentioned this pull request Nov 1, 2018

Update jest in / from 22.1.4 to 23.6.0 leonardofaria/leozera-ui#250

Closed

aymericbouzy mentioned this pull request Jan 17, 2019

Writing tests without a function #7644

Closed

snyk-bot mentioned this pull request Mar 17, 2020

[Snyk] Upgrade expect from 23.0.0 to 23.6.0 yowainwright/react-workshop#8

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add error throwing to 'it'/'test' for incorrect arguments. #5558

Add error throwing to 'it'/'test' for incorrect arguments. #5558

brianlmacdonald commented Feb 14, 2018 •

edited

Loading

codecov-io commented Feb 14, 2018 •

edited

Loading

SimenB Feb 14, 2018

SimenB Feb 14, 2018

brianlmacdonald Feb 14, 2018

SimenB Feb 14, 2018

cpojer Feb 14, 2018

SimenB Feb 14, 2018

SimenB Feb 14, 2018

SimenB Feb 14, 2018

brianlmacdonald Feb 14, 2018

brianlmacdonald Feb 14, 2018

SimenB Feb 15, 2018

SimenB Feb 15, 2018

brianlmacdonald Feb 15, 2018 •

edited

Loading

SimenB Feb 15, 2018

brianlmacdonald Feb 15, 2018

thymikee Feb 15, 2018

SimenB Feb 16, 2018 •

edited

Loading

SimenB Feb 16, 2018

brianlmacdonald Feb 16, 2018

brianlmacdonald Feb 20, 2018

shellscape commented May 30, 2018

elyobo commented Jun 13, 2018

github-actions bot commented May 12, 2021

Add error throwing to 'it'/'test' for incorrect arguments. #5558

Add error throwing to 'it'/'test' for incorrect arguments. #5558

Conversation

brianlmacdonald commented Feb 14, 2018 • edited Loading

Summary

Test plan

codecov-io commented Feb 14, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brianlmacdonald Feb 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB Feb 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shellscape commented May 30, 2018

elyobo commented Jun 13, 2018

github-actions bot commented May 12, 2021

brianlmacdonald commented Feb 14, 2018 •

edited

Loading

codecov-io commented Feb 14, 2018 •

edited

Loading

brianlmacdonald Feb 15, 2018 •

edited

Loading

SimenB Feb 16, 2018 •

edited

Loading