Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove retainLines from babel-jest #5439

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Remove retainLines from babel-jest #5439

merged 1 commit into from
Feb 2, 2018

Conversation

jessecarfb
Copy link
Contributor

Summary
Per #5326, babel has an issue with retainLines that causes failures on decorators with async methods. Since babel already provides sourcemaps, we don't need to retainLines

Test plan
yarn test passed

@codecov-io
Copy link

Codecov Report

Merging #5439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5439   +/-   ##
=======================================
  Coverage   62.18%   62.18%           
=======================================
  Files         205      205           
  Lines        6928     6928           
  Branches        3        3           
=======================================
  Hits         4308     4308           
  Misses       2619     2619           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea270b...b5de153. Read the comment docs.

@cpojer cpojer merged commit 6635d93 into jestjs:master Feb 2, 2018
@cpojer
Copy link
Member

cpojer commented Feb 2, 2018

Nice!

@SimenB
Copy link
Member

SimenB commented Feb 2, 2018

Would love to remove https://github.com/facebook/jest/blob/6635d93fc3813d386af73ff226db0bffd30a753d/.babelrc#L12 as well 🙂

SimenB
SimenB reviewed Feb 2, 2018
View reviewed changes
CHANGELOG.md
@@ -7,6 +7,8 @@

### Fixes

* `[babel-jest]` Remove retainLines from babel-jest
([#5326](https://github.com/facebook/jest/issues/5326))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should link to the PR, not issue.

@rickhanlonii rickhanlonii mentioned this pull request Feb 2, 2018
Merged
SimenB added a commit to SimenB/jest that referenced this pull request Feb 8, 2018
@SimenB
Revert "Remove retainLines from babel-jest (jestjs#5439)"
a064cd9 
This reverts commit 6635d93.
cpojer pushed a commit that referenced this pull request Feb 8, 2018
@SimenB @cpojer
Revert "Remove retainLines from babel-jest (#5439)" (#5496)
3942361 
* Revert "Remove retainLines from babel-jest (#5439)"

This reverts commit 6635d93.

* changelog

* moar changelog
@renovate renovate bot mentioned this pull request Feb 14, 2018
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB left review comments

Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessecarfb @codecov-io @cpojer @SimenB @facebook-github-bot