Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moduleFileExtensions extensions is now passed to babel-jest #5110

Merged
merged 6 commits into from
Dec 22, 2017
Merged

moduleFileExtensions extensions is now passed to babel-jest #5110

merged 6 commits into from
Dec 22, 2017

Conversation

drownbes
Copy link
Contributor

Fix for issue #4637.

Transform extensions hardcoded in babel-core 6. Pull request make moduleFileExtensions option to be passed to babel-core as `altExts'.

@SimenB
Copy link
Member

SimenB commented Dec 18, 2017

Can you add a test showing what it enables?

And please update the changelog as well

Added test to show use of custom files extensions with babel-jest
c758227 
CHANGELOG: moduleFileExtensions now passed to babel transformer
SimenB
SimenB reviewed Dec 20, 2017
View reviewed changes
integration_tests/transform/ecmascript-modules-support/yarn.lock Outdated
@@ -0,0 +1,550 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

SimenB
SimenB reviewed Dec 20, 2017
View reviewed changes
integration_tests/transform/ecmascript-modules-support/package.json Outdated
@@ -0,0 +1,14 @@
{
"dependencies": {
"babel-preset-env": "^1.6.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a dependency on babel-preset-env in the root already, so this is not needed https://github.com/facebook/jest/blob/1521c516c2cae8f4bfe41605640f273f9c17fb87/package.json#L18

SimenB
SimenB reviewed Dec 20, 2017
View reviewed changes
integration_tests/__tests__/transform.test.js Outdated
@@ -120,3 +120,25 @@ describe('multiple-transformers', () => {
expect(json.numPassedTests).toBe(1);
});
});

describe('ecmascript-modules-support', () => {
skipOnWindows.suite();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to skip it on windows?

@codecov-io
Copy link

codecov-io commented Dec 20, 2017 •
edited
Loading

Codecov Report

Merging #5110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5110   +/-   ##
======================================
  Coverage    60.7%   60.7%           
======================================
  Files         201     201           
  Lines        6691    6691           
  Branches        4       4           
======================================
  Hits         4062    4062           
  Misses       2628    2628           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1521c51...b65d8c8. Read the comment docs.

Cleanup
cf1a3cc 
Cleaned integration_tests/transform/ecmascript-modules-support/yarn.lock
Cleaned integration_tests/transform/ecmascript-modules-support/package.json
Enable testing on windows
SimenB
SimenB reviewed Dec 20, 2017
View reviewed changes
integration_tests/transform/ecmascript-modules-support/yarn.lock Outdated
@@ -0,0 +1,549 @@
# yarn lockfile v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant delete this whole file, not the first line in particular 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

SimenB
SimenB requested changes Dec 20, 2017
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Could you add a line to the changelog as well, and I think this is good to go!

@drownbes
Copy link
Contributor Author

Under which version?

@SimenB
Copy link
Member

SimenB commented Dec 20, 2017

Do the same as https://github.com/facebook/jest/pull/5138/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

@cpojer cpojer merged commit 043a8b2 into jestjs:master Dec 22, 2017
@drownbes drownbes deleted the mjs-files-babel-jest branch December 25, 2017 07:47
@SimenB SimenB mentioned this pull request Dec 27, 2017
Closed
@renovate-tests renovate-tests mentioned this pull request Feb 6, 2018
Closed
@renovate renovate bot mentioned this pull request Feb 14, 2018
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drownbes @SimenB @codecov-io @cpojer @facebook-github-bot