Add support for date in jest-get-type #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Oct 7, 2017
| | 'string' | ||
| | 'symbol' | ||
| | 'undefined'; | ||
|
|
||
| // get the type of a value with handling the edge cases like `typeof []` | ||
| // and `typeof null` | ||
| const getType = (value: any): ValueType => { | ||
| if (typeof value === 'undefined') { | ||
| if (value === undefined) { |
There was a problem hiding this comment.
undefined is read only in ES5 and up, so no reason for this check (unless I'm missing something really obvious)
Codecov Report
@@ Coverage Diff @@
## master #4621 +/- ##
==========================================
+ Coverage 56.17% 56.18% +0.01%
==========================================
Files 194 194
Lines 6544 6546 +2
Branches 3 3
==========================================
+ Hits 3676 3678 +2
Misses 2867 2867
Partials 1 1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for type
datetojest-get-type.Btw, any reason why
jest-get-typeexists, over just using kindof (or some other module doing the same thing)?Test plan
New test added