Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changedFilesWithAncestor #4193

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

aaronabramov
Copy link
Contributor

adding anything to defaults.js makes it not overwritable :'(

won't write a test cause it's a super edge case

@codecov-io
Copy link

Codecov Report

Merging #4193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4193   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         198      198           
  Lines        6781     6781           
  Branches        6        6           
=======================================
  Hits         4086     4086           
  Misses       2692     2692           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-config/src/defaults.js 85.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aec432...74173a6. Read the comment docs.

@cpojer cpojer merged commit 3e2120f into jestjs:master Aug 4, 2017
@cpojer
Copy link
Member

cpojer commented Aug 4, 2017

I would say that if it's a super edge-case, writing a test for it is super important ;)

@aaronabramov aaronabramov deleted the changed_files_with_ancestor_fix branch August 4, 2017 16:08
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants