Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix watch mode #4084

Merged
merged 1 commit into from
Jul 20, 2017
Merged

fix watch mode #4084

merged 1 commit into from
Jul 20, 2017

Conversation

aaronabramov
Copy link
Contributor

We really need to have this: #4022
right now watch mode is almost untested and we break it too often with the build being all green 😞

aaronabramov
aaronabramov commented Jul 20, 2017
View reviewed changes
packages/jest-cli/src/__tests__/watch_filename_pattern_mode.test.js
@@ -135,7 +135,7 @@ describe('Watch mode flows', () => {

// globalConfig is updated with the current pattern
expect(runJestMock.mock.calls[0][0].globalConfig).toEqual({
onlyChanged: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the correct value. If we have a pattern, we don't match only changed files, we match all files

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e8ed43e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4084   +/-   ##
=========================================
  Coverage          ?   60.45%           
=========================================
  Files             ?      196           
  Lines             ?     6774           
  Branches          ?        6           
=========================================
  Hits              ?     4095           
  Misses            ?     2676           
  Partials          ?        3
Impacted Files Coverage Δ
packages/jest-cli/src/lib/update_global_config.js 90.47% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ed43e...e841298. Read the comment docs.

@cpojer cpojer merged commit f736672 into jestjs:master Jul 20, 2017
@aaronabramov aaronabramov deleted the watch_mode_fx branch July 20, 2017 17:22
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@aaronabramov @cpojer
fix watch mode (jestjs#4084)
aac433d
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronabramov @codecov-io @cpojer @facebook-github-bot