Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build script printing small-terminals-friendly #3892

Merged
merged 5 commits into from
Jun 26, 2017

Conversation

thymikee
Copy link
Collaborator

Summary

It kind of always pissed me a bit that the build script outputs fixed width strings.
How about changing that?

before after
screen shot 2017-06-23 at 22 48 58 screen shot 2017-06-23 at 22 47 43

Test plan

Tested on iTerm2 and Terminal (mac)

@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #3892 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3892   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         195      195           
  Lines        6741     6741           
  Branches        6        6           
=======================================
  Hits         3911     3911           
  Misses       2827     2827           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1199558...1c44f73. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented Jun 26, 2017

pls rebase

@thymikee
Copy link
Collaborator Author

Rebased

@cpojer cpojer merged commit 5577ece into jestjs:master Jun 26, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Make build script printing small-terminals-friendly

* Debug windows

* Fallback on undefined stdout.columns

* Bring back 'editor.formatOnSave'

* Update yarn.lock
@thymikee thymikee deleted the build-script-printing branch March 16, 2019 10:55
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants