-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define separate type for pretty-format plugin Options #3802
Conversation
types/PrettyFormat.js
Outdated
@@ -40,6 +38,12 @@ export type Options = {| | |||
|}, | |||
|}; | |||
|
|||
export type Options = {| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about PluginOptions
? We could leave the old name of PrettyOptions
then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you for good direction.
Codecov Report
@@ Coverage Diff @@
## master #3802 +/- ##
=======================================
Coverage 58.01% 58.01%
=======================================
Files 195 195
Lines 6741 6741
Branches 6 6
=======================================
Hits 3911 3911
Misses 2827 2827
Partials 3 3
Continue to review full report at Codecov.
|
Sure! |
* Define separate type for pretty-format plugin Options * Rename separate type as PluginOptions
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The type improvements in #3095 accidentally added
edgeSpacing
andspacing
to the public interface ofpretty-format
min
option: https://github.com/facebook/jest/blob/master/packages/pretty-format/src/index.js#L908-L909EDIT: in plugins, replace
Options
with new minimalPluginOptions
typeTest plan
Jest