Prevent babelrc package import failure on relative current path #3723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to danger/danger-js#261 .
This PR attempts to fix cases of reading babelrc via
package.json
. Using current code path, below case is possible:I thought of using different mechanics to detect relative current (i.e
path.relative(directory, '.')
,path.resolve(directory, __dirname)
..) but took simplest comparison instead.Test plan
I've verified by replacing this module uses it as dependency (danger/danger-js#261)