-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/transform refresh #3334
Bugfix/transform refresh #3334
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
ff84fd5
to
5f4eb68
Compare
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #3334 +/- ##
=======================================
Coverage 65.07% 65.07%
=======================================
Files 178 178
Lines 6539 6539
Branches 4 4
=======================================
Hits 4255 4255
Misses 2283 2283
Partials 1 1
Continue to review full report at Codecov.
|
Thank you! I removed some of the changes you made and took a note to update this code soon because we are refactoring how configurations are working. |
* Retransform if the relevant configuration is changed * Correct lint errors * Write unit test * Some reverts.
* Retransform if the relevant configuration is changed * Correct lint errors * Write unit test * Some reverts.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Correct the bug describe in issue3333
Test plan
Test added and passed.