Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve custom puppeteer example to prevent worker warnings #13619

Merged
merged 1 commit into from
Jan 1, 2023
Merged

docs: improve custom puppeteer example to prevent worker warnings #13619

merged 1 commit into from
Jan 1, 2023

Conversation

falsyvalues
Copy link
Contributor

Summary

Environment have to call disconnect during teardown otherwise it will generate a warning:

A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

Test plan

Just docs update ✌️

SimenB
SimenB approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! can you update all versions of this doc?

image

@falsyvalues falsyvalues changed the title docs: improve custom example to prevent worker warnings docs: improve custom puppeteer example to prevent worker warnings Nov 17, 2022
@falsyvalues
docs: improve custom puppeteer example to prevent worker warnings
e0f0fe3 
Prevents from warnings: A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.
@falsyvalues falsyvalues force-pushed the docs/puppeteer-recipe branch from f35463a to e0f0fe3 Compare November 17, 2022 20:25
@falsyvalues
Copy link
Contributor Author

@SimenB Sure thing, done.

@SimenB SimenB merged commit e9f0d03 into jestjs:main Jan 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@falsyvalues @SimenB @facebook-github-bot