feat(@jest/environment, jest-runtime): allow requireActual and requireMock to take a type argument
#13253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Sep 13, 2022
Comment on lines
-2132
to
+2133
| requireActual: this.requireActual.bind(this, from), | ||
| requireMock: this.requireMock.bind(this, from), | ||
| requireActual: moduleName => this.requireActual(from, moduleName), | ||
| requireMock: moduleName => this.requireMock(from, moduleName), |
There was a problem hiding this comment.
Is this fine? Not sure I understand what bind does here. Rework it, because I couldn’t find a clean way to return T through bind. Only work around was though casting, but this way it looked cleaner. All test are passing locally, let’s see what CI thinks.
mrazauskas
commented
Sep 13, 2022
Comment on lines
-429
to
+427
| getRandom: jest.fn().mockReturnValue(10), | ||
| getRandom: jest.fn(() => 10), |
There was a problem hiding this comment.
This way it doesn’t require additional typings in TS example. Less noise.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #13199 (comment)
Summary
Currently
jest.requireActualandjest.requireMockreturnunknown. It is possible to useas typeof import('../someModule')to cast the return value. At the same time, it is somewhat nicer to do this via generic type argument:Test plan
Type tests are added.