fix: pipe workerIdleMemoryLimit to globalConfig

[backmask]

Summary

New argument workerIdleMemoryLimit did not get forwarded from package.json to the workers. This fixes it. Context: #11956 (comment)

Test plan

Tested manually, added a console.log in TestRunner::createParallelTestRun, saw an undefined workerIdleMemoryLimit without the fix. Works with the fix

The following entry has to be added to package.json to test the fix

  "jest": {
    "workerIdleMemoryLimit": "500MB"
  },

[facebook-github-bot]

Hi @backmask!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[SimenB]

Ugh, almost same as #13105. Feels like we should have some tests it's properly threaded through 😅

[SimenB]

@backmask this fixes both the issues you mentioned in the linked comment?

[backmask]

@backmask this fixes both the issues you mentioned in the linked comment?

This fixes the first issue (the flag having no effect). It does not fix workers being killed and not respawning. For the second bug, I haven't found a fix or if I have done a misconfiguration. I will let you know if I find anything!

[phawxby]

@backmask this fixes both the issues you mentioned in the linked comment?

This fixes the first issue (the flag having no effect). It does not fix workers being killed and not respawning. For the second bug, I haven't found a fix or if I have done a misconfiguration. I will let you know if I find anything!

Back from vacation, investigating now

[phawxby]

@backmask this fixes both the issues you mentioned in the linked comment?

This fixes the first issue (the flag having no effect). It does not fix workers being killed and not respawning. For the second bug, I haven't found a fix or if I have done a misconfiguration. I will let you know if I find anything!

Your analysis is mostly correct... The workers are being killed, they are respaning, the request to re-run the request is being sent then just nothing. The plot thickens.

{ limit: 200000000, childUsage: 238479704, restart: true, pid: 89632 }
{ preState: 'restarting', state: 'ok', prePid: 89632, postPid: 89655 }
RESENDING REQUEST [
  1,
  true,
  'worker',
  [
    {
      config: [Object],
      context: [Object],
      globalConfig: [Object],
      path: '/Users/paul/Documents/GitHub/brand-engine/src/common/helpers/express/__tests__/listenForStatusCode.test.ts'
    }
  ]
]

As for the config fix above, that works correctly and should be merged.

[phawxby]

I currently have no idea why but this promise is not resolving in a worker that has been restarted.
https://github.com/facebook/jest/blob/main/packages/jest-runner/src/testWorker.ts#L95

[phawxby]

I have a test case for the issue as part of a new e2e test.
#13107

I should've created one of these in the original PR and we wouldn't have had these issues.

Heading to bed now, tomorrow will be trying to figure out why it's misbehaving.

[SimenB]

let's land this in the meantime as it's a correct tweak 🙂

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.