-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing the toHaveProperty
matcher to support array selection
#12092
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12092 +/- ##
==========================================
+ Coverage 68.89% 68.90% +0.01%
==========================================
Files 324 324
Lines 16668 16677 +9
Branches 4813 4814 +1
==========================================
+ Hits 11483 11492 +9
Misses 5152 5152
Partials 33 33
Continue to review full report at Codecov.
|
e3515c3
to
794c62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Hi, this PR is adding the feature requested at #7284 as mentioned #7284 (comment) to support array selection while using the
toHaveProperty
matcher.Test plan
All previous matchers tests are working as expected, and I've also added more test cases to test the functionality, let me know if I need to add more tests.