feat(jest-haste-map): support dependencyExtractor written in ESM

[chentsulin]

Summary

Part of #11167.

See the discussion on the dependencyExtractor config: #11167 (comment)

Test plan

• Integration test added.
• Converted new HasteMap(...) calls to await HasteMap.create(...)
• Converted Runtime.createHasteMap(...) calls to await Runtime.createHasteMap(...)

[SimenB]

code in general looks good, but this makes it a breaking change and must wait for Jest 28 🙂 I'll add it to the milestone so we don't forget

[chentsulin]

I am not quite sure we should accept extract named export or a default export here.

named export:

export function extract(code, filePath) {
  const dependencies = new Set();
  if (filePath.includes('skip-deps')) {
    return dependencies;
  }
  const addDependency = (match, pre, quot, dep, post) => {
    dependencies.add(dep);
    return match;
  };
  code.replace(DYNAMIC_IMPORT_RE, addDependency);
  return dependencies;
};

default export:

export default {
  extract(code, filePath) {
    const dependencies = new Set();
    if (filePath.includes('skip-deps')) {
      return dependencies;
    }
    const addDependency = (match, pre, quot, dep, post) => {
      dependencies.add(dep);
      return match;
    };
    code.replace(DYNAMIC_IMPORT_RE, addDependency);
    return dependencies;
  }
}

[SimenB]

Hey! I've started to land breaking changes, so if you rebase this we can see where we're at? 🙂

[chentsulin]

Ok. I've done the rebase.

[SimenB]

Awesome, thanks! I think I've commented on the two open questions?

[chentsulin]

@SimenB I am not sure if this is a valid e2e test of ESM dependency extractor. I just found a commonjs version above and did the same against ESM.

[SimenB]

that's fine 👍

[SimenB]

thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.