fix: pass matcher context to asymmetric matchers #11926
Merged
+83
−81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This exposes that asymmetric matchers are not called withthis
- which IMO is a bug. For now I've stuck a@ts-ignore
there, but we should fix itAsymmetric matchers were not called with matcher context - meaning they didn't have access to
this.equals
,this.utils
etc..First commit makes TypeScript highlight that as an error, second commit fixes passing
this
.Test plan
Green CI