feat: support conditions from test environments
#11863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #11863 +/- ##
=======================================
Coverage 68.93% 68.93%
=======================================
Files 312 312
Lines 16411 16412 +1
Branches 4759 4760 +1
=======================================
+ Hits 11313 11314 +1
Misses 5071 5071
Partials 27 27
Continue to review full report at Codecov.
|
SimenB
force-pushed
the
conditions-env
branch
from
4d0902c to
64bda74
Compare
SimenB
commented
Sep 13, 2021
| @@ -42,6 +42,7 @@ export declare class JestEnvironment<Timer = unknown> { | |||
| setup(): Promise<void>; | |||
| teardown(): Promise<void>; | |||
| handleTestEvent?: Circus.EventHandler; | |||
| exportConditions?: () => Array<string>; | |||
There was a problem hiding this comment.
this could probably be a property, but making it into a function seems fine for a bit more flexibility
AndrewSouthpaw
added a commit
to AndrewSouthpaw/jest
that referenced
this pull request
Sep 23, 2021
…nsform-ignore-patterns * 'main' of https://github.com/facebook/jest: (38 commits) chore: update `npm` instructions in README (jestjs#11890) chore: force patched version of ansi-regex (jestjs#11889) chore: update lockfile after publish v27.2.1 chore: update changelog for release make the syntax error message more helpful for TS users (jestjs#11807) fix: include path to test file in "after teardown" error (jestjs#11885) docs: add link to the typescript integration instructions (jestjs#11806) fix: properly return mocks when using jest.isolatedModules (jestjs#11882) chore: remove node version pinning from CI (jestjs#11866) chore: remove node 13 as condition in some tests (jestjs#11880) chore: fix typo in docs chore: update lockfile after publish v27.2.0 chore: roll new website version chore: update changelog for release chore: update lock feat: support `conditions` from test environments (jestjs#11863) Revert "chore: remove unneeded yarn patch for react native (jestjs#11853)" chore: supress experimental warnings in tests ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows custom test environments to pass extra
conditionsfor Jest to pass on to custom resolver, such asnodeorbrowser.Depends on (and includes as the first commit) #11859./cc @nicolo-ribaudo
Test plan
Tests added