fix(jest-environment-node): Add Event and EventTarget to node global #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smrtnyk
reviewed
Aug 4, 2021
| @@ -66,6 +66,14 @@ class NodeEnvironment implements JestEnvironment { | |||
| if (typeof AbortController !== 'undefined') { | |||
| global.AbortController = AbortController; | |||
| } | |||
| // Event is global in Node >= 15.4 | |||
| if (typeof Event !== 'undefined') { | |||
There was a problem hiding this comment.
Do you know maybe if there are tests that test other globals from this file?
If so it would make sense to have tests for this logic also.
Other than that, good catch and fix.
There was a problem hiding this comment.
I could not find any existing tests around making globals available. It's possible I missed them, but I was decently thorough.
splincode
pushed a commit
to splincode/jest
that referenced
this pull request
Aug 24, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Event and EventTarget to node global, if available (starting in Node 15.4+). Fixes #11705.
Test plan
No existing pattern of testing of exposing environment globals could be found, but one can can test it by trying to see if Event and EventTarget are available to node test environments: https://github.com/jayphelps/jest-event-demo