-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-each] Relaxed the validation to allow multibyte characters in headings #11575
Conversation
@SimenB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Could you add a test and a changelog entry? 🙂
32e246b
to
3206df2
Compare
Codecov Report
@@ Coverage Diff @@
## master #11575 +/- ##
==========================================
- Coverage 69.01% 69.00% -0.01%
==========================================
Files 312 312
Lines 16339 16339
Branches 4736 4736
==========================================
- Hits 11276 11275 -1
- Misses 5035 5036 +1
Partials 28 28
Continue to review full report at Codecov.
|
@SimenB We've added a few test cases to simply check some of Unicode characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I fixed to be able to use Japanese and multibyte strings in the headings of
jest.each
as in Jest 26.Since the release of Jest 27.0.0, Japanese headings are no longer available in jest-each.
The test case is as follows:
The output is follows:
I use Japanese in jest.each a lot, and I think that makes the test cases easier to understand.
Test plan
This PR works fine the test case above: