fix(findRelatedTests): edge cases with --findRelatedTests on Windows #11548
Conversation
Allow hidden directories and special characters with `--findRelatedTests` on windows. * `jest --findRelatedTests packages/@core/my-app.ts` * `jest --findRelatedTests packages/.hidden/my-hidden-app.ts` * `jest --findRelatedTests 'packages/programs (x86)/my-hidden-app.ts'`
Codecov Report
@@ Coverage Diff @@
## master #11548 +/- ##
==========================================
+ Coverage 68.94% 68.98% +0.04%
==========================================
Files 312 312
Lines 16314 16319 +5
Branches 4726 4726
==========================================
+ Hits 11247 11257 +10
+ Misses 5039 5034 -5
Partials 28 28
Continue to review full report at Codecov.
|
|
🥳 |
|
I don't know why CI is failing now. Probably unrelated..? |
|
@SimenB thanks a lot! This will help the Stryker community 💖 I was wondering: why is there separate win32 logic in the first place? Couldn't we simply remove it entirely? |
No idea 😅 We can try to remove it and see what CI says? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Allow hidden directories and special characters with
--findRelatedTestson windows.jest --findRelatedTests packages/@core/my-app.tsjest --findRelatedTests packages/.hidden/my-hidden-app.tsjest --findRelatedTests 'packages/programs (x86)/my-hidden-app.ts'Fixes #11534
Fixes #9728
Test plan
I've tested this against the reproduction repo provided by @blephy in #11534 (comment)
I also added unit tests for this, which run on both linux and windows in CI