fix dependency issues #11465
Merged
fix dependency issues #11465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
May 27, 2021
| @@ -1056,6 +1056,10 @@ export default async function normalize( | |||
| rootDir: options.rootDir, | |||
| }); | |||
|
|
|||
| if (newOptions.runner === DEFAULT_CONFIG.runner) { | |||
There was a problem hiding this comment.
if it's not the default, it'll be resolved in the switch above
jeysal
approved these changes
May 27, 2021
SimenB
commented
May 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #11465 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 312 312
Lines 16301 16305 +4
Branches 4717 4720 +3
=======================================
+ Hits 11276 11279 +3
- Misses 4997 4998 +1
Partials 28 28
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11452.
The
slashone fools the eslint plugin as it usesimport slash = require('slash')syntax.The other change is because
jest-utilcannot access unresolved modules passed to it.normalizeinjest-configshould ideally just pass absolute strings through in config. I've also added the dependency, so it can resolve it.Test plan
The changed check in
requireOrImportModulethrew without therequire.resolve.