fix(runtime): handle async transforms of same module #11220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Mar 20, 2021
| referencingModule.context, | ||
| ); | ||
| try { | ||
| const module = new SourceTextModule(transformedCode, { |
Codecov Report
@@ Coverage Diff @@
## master #11220 +/- ##
==========================================
- Coverage 64.30% 64.24% -0.07%
==========================================
Files 309 309
Lines 13485 13500 +15
Branches 3286 3288 +2
==========================================
+ Hits 8672 8673 +1
- Misses 4104 4118 +14
Partials 709 709
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code currently ends up putting duplicate modules into the module cache, leading to different instances added to the cache (or rather, newer ones overriding old ones) which breaks referential identity.
We now have a sort of mutex on the cache key as well as asserting the cache does not have an entry for the cache key before we put the module into it.
Fixes #11214.
Test plan
Test added