fix: don't assume stack is always a string

[snitin315]

Summary

Fixes #10681

Test plan

Before

After

[SimenB]

Can you add an integration test which does throw {stack: 42} or something? I think we can make improvements to the stack, but seeing how it looks in both jasmine and circus first would be nice 🙂 Since what's thrown is not an error we'll have to point to the test definition, but that's better than nothing.

Adding a case here and adding some assertions somewhere around here should work out: https://github.com/facebook/jest/blob/2dafb09d51584d3785f3280f569784ec4334b5d8/e2e/__tests__/failures.test.ts#L30-L54

[SimenB]

see #10697 (comment)

[snitin315]

I have added an integration test 💯 .

[SimenB]

@snitin315 thanks! I pushed up one more failing test I'd like to se a better error for. I'll be happy to give you a hand if you get stuck attempting to fix it 👍

[snitin315]

Looking into it 👍🏻

[SimenB]

Thanks! That snapshot should look like the snapshot of Object thrown during test

[snitin315]

Yeah, I got it.

[snitin315]

@SimenB it's like this now, Not sure why CI is failing for Node 10

[SimenB]

Looks good! Not sure about node 10, but let's look into that after fixing the test for jest-circus. You can run that locally via JEST_CIRCUS=1 yarn jest failures.

[SimenB]

@snitin315 I pushed the fix for Node 10. We just need to fix the test for Jest Circus and this should be ready to land 👍

[snitin315]

@snitin315 I pushed the fix for Node 10. We just need to fix the test for Jest Circus and this should be ready to land

@SimenB Thanks!, I am working on Jest Circus I will push soon.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.