Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add missing options for timers on config.ts file #10632

Merged
merged 3 commits into from
Oct 14, 2020
Merged

refactor: add missing options for timers on config.ts file #10632

merged 3 commits into from
Oct 14, 2020

Conversation

ftonato
Copy link
Contributor

@ftonato ftonato commented Oct 13, 2020

Summary

@jest/types config in Config.ts has missing value(s) for timers in two variables InitialOptions and DefaultOptions.

Closes #10609

jeysal
jeysal reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

packages/jest-types/src/Config.ts Outdated Show resolved Hide resolved
SimenB
SimenB approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add an entry to the changelog as well?

@ftonato
Copy link
Contributor Author

ftonato commented Oct 14, 2020

Yes, I will do it!

@SimenB SimenB merged commit e84a70c into jestjs:master Oct 14, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@jest/types config is missing timers option
4 participants
@ftonato @SimenB @jeysal @facebook-github-bot