Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsdom version #3655

Closed
flaviut opened this issue May 25, 2017 · 5 comments
Closed

Update jsdom version #3655

flaviut opened this issue May 25, 2017 · 5 comments

Comments

@flaviut
Copy link

flaviut commented May 25, 2017

jest currently uses [email protected], which is kinda old and has a few bugs that I'd like fixed.

I'd like to bump the jsdom version to 11.0.0. The API is completely different, but it should be straightforward to migrate since jest doesn't do anything complicated with it.

jsdom@11 doesn't support node v4 though. I think that might be a problem--it looks like jest tries to support node v4: https://github.com/facebook/jest/blob/master/circle.yml#L13

@cpojer
Copy link
Member

cpojer commented May 25, 2017

You can fork jest-environment-jsdom and build your own version of it that uses another version of jsdom :) Then use that using testEnvironment.

@thymikee
Copy link
Collaborator

@flaviut yes, Jest still supports Node 4, that's why we can't really use jsdom@10+. I'll close this issue, but will definitely revisit after we drop Node 4, probably near its EOL which is in a year.

@flaviut
Copy link
Author

flaviut commented May 26, 2017

Great, I'll go ahead and do that! Thank you for the suggestion, I didn't know that was possible.

Edit: If anyone else comes across this issue, I'd like to mention that this package is now on npm.

@code-smith
Copy link

@flaviut how do i use this npm download?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants