Skip to content

Commit

Permalink
fix(eslint): use eslint-import-resolver-typescript to fix import/no-u…
Browse files Browse the repository at this point in the history
…nresolved (#12016)
  • Loading branch information
chentsulin authored Nov 29, 2021
1 parent eb5b7d3 commit 40a9027
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -485,5 +485,8 @@ module.exports = {
'import/internal-regex': new RegExp(
internalPackages.map(pkg => `^${pkg}$`).join('|'),
).source,
'import/resolver': {
typescript: {},
},
},
};
2 changes: 2 additions & 0 deletions e2e/native-esm/__tests__/native-esm.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ import staticImportedStatefulFromCjs from '../fromCjs.mjs';
import {double} from '../index';
import defaultFromCjs, {half, namedFunction} from '../namedExport.cjs';
import {bag} from '../namespaceExport.js';
/* eslint-disable import/no-duplicates */
import staticImportedStateful from '../stateful.mjs';
import staticImportedStatefulWithQuery from '../stateful.mjs?query=1';
import staticImportedStatefulWithAnotherQuery from '../stateful.mjs?query=2';
/* eslint-enable import/no-duplicates */

test('should have correct import.meta', () => {
expect(typeof require).toBe('undefined');
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"dedent": "^0.7.0",
"eslint": "^7.7.0",
"eslint-config-prettier": "^8.1.0",
"eslint-import-resolver-typescript": "^2.5.0",
"eslint-plugin-eslint-comments": "^3.1.2",
"eslint-plugin-import": "^2.6.0",
"eslint-plugin-jest": "^24.0.0",
Expand Down
21 changes: 19 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2584,6 +2584,7 @@ __metadata:
dedent: ^0.7.0
eslint: ^7.7.0
eslint-config-prettier: ^8.1.0
eslint-import-resolver-typescript: ^2.5.0
eslint-plugin-eslint-comments: ^3.1.2
eslint-plugin-import: ^2.6.0
eslint-plugin-jest: ^24.0.0
Expand Down Expand Up @@ -9211,6 +9212,22 @@ __metadata:
languageName: node
linkType: hard

"eslint-import-resolver-typescript@npm:^2.5.0":
version: 2.5.0
resolution: "eslint-import-resolver-typescript@npm:2.5.0"
dependencies:
debug: ^4.3.1
glob: ^7.1.7
is-glob: ^4.0.1
resolve: ^1.20.0
tsconfig-paths: ^3.9.0
peerDependencies:
eslint: "*"
eslint-plugin-import: "*"
checksum: c13542b1f6283ac354c151f11f5e6e6fb69471ed66c6b6491a72a1ead3504404bf3dca830c9b093e26d419c89ee48433ba45cab1e3a1c3fb968fc7ffa9454cad
languageName: node
linkType: hard

"eslint-module-utils@npm:^2.6.2":
version: 2.6.2
resolution: "eslint-module-utils@npm:2.6.2"
Expand Down Expand Up @@ -10743,7 +10760,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"glob@npm:^7.0.0, glob@npm:^7.0.3, glob@npm:^7.1.1, glob@npm:^7.1.2, glob@npm:^7.1.3, glob@npm:^7.1.4, glob@npm:^7.1.6":
"glob@npm:^7.0.0, glob@npm:^7.0.3, glob@npm:^7.1.1, glob@npm:^7.1.2, glob@npm:^7.1.3, glob@npm:^7.1.4, glob@npm:^7.1.6, glob@npm:^7.1.7":
version: 7.2.0
resolution: "glob@npm:7.2.0"
dependencies:
Expand Down Expand Up @@ -21002,7 +21019,7 @@ [email protected]:
languageName: node
linkType: hard

"tsconfig-paths@npm:^3.11.0":
"tsconfig-paths@npm:^3.11.0, tsconfig-paths@npm:^3.9.0":
version: 3.11.0
resolution: "tsconfig-paths@npm:3.11.0"
dependencies:
Expand Down

0 comments on commit 40a9027

Please sign in to comment.