Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roundAsCircle does not apply #9

Closed
hw3jung opened this issue Mar 27, 2015 · 8 comments
Closed

roundAsCircle does not apply #9

hw3jung opened this issue Mar 27, 2015 · 8 comments

Comments

@hw3jung
Copy link

hw3jung commented Mar 27, 2015

Hi,

I've specified the XML attribute, fresco:roundAsCircle="true", in the following code and the image is still displaying as a square.

< com.facebook.drawee.view.SimpleDraweeView
android:id="@+id/profile_picture"
android:layout_width="45dp"
android:layout_height="45dp"
android:layout_centerVertical="true"
android:layout_marginEnd="10dp"
android:layout_marginRight="10dp"
fresco:roundAsCircle="true"/>

I've made sure to add the custom namespace, fresco, to the top-level element:

< android.support.v7.widget.CardView
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:card_view="http://schemas.android.com/apk/res-auto"
xmlns:fresco="http:/schemas.android.com/apk/res-auto"
...>

@plamenko
Copy link
Contributor

That's strange. Since there was a similar report, I wonder whether there is some systematic issue.
Can you please try fresco:roundWithOverlayColor="@android:color/red" and tell what happens? That will help us narrow down the issue.

@hw3jung
Copy link
Author

hw3jung commented Mar 27, 2015

I received the following error:

Error:(37, 47) No resource found that matches the given name (at 'roundWithOverlayColor' with value '@android:color/red').

@plamenko
Copy link
Contributor

It seems that for some reason our attrs.xml is not included in your app:
https://github.com/facebook/fresco/blob/master/drawee/src/main/res/values/attrs.xml

@plamenko
Copy link
Contributor

Actually, I may have made a mistake, can you just specify some color instead of @android:color/red?

@hw3jung
Copy link
Author

hw3jung commented Mar 27, 2015

Yeah just tried with some color, and now the app compiles again but I don't see the overlay color either (also image is still not a circle).

@leicht-io
Copy link

I am having the same error, but without exception. The circular view is simple not being drawed.

@tapanmodh
Copy link

Same Issue. The circular view is not being drawed. It is showing as rectangle image.

@IanChilds
Copy link
Contributor

It looks as though the issue is a typo in the documentation. It should be http://schemas.android.com/apk/res-auto rather than http:/schemas.android.com/apk/res-auto (note the extra '/')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants