Folly DistributedMutex using unavailable methods. #1527
Comments
|
The reason for the gcc/clang version? https://en.cppreference.com/w/cpp/atomic/atomic_notify_one |
|
Happening for me too. Please address this. Xcode release is coming out like tomorrow. |
|
React Native builds are also broken because of this. |
|
Do you know which commit triggered this? The line of code you're referring to has been there for more than 2 years now. |
|
@Orvid Like we said it's not a commit it's the Xcode Beta itself that breaks this. |
|
Apologies for addressing this a bit late. We have a potential fix, working on it... |
Summary: `std::atomic_wait()` and `std::atomic_notify_one()` are marked as unavailable. Not really sure what that means, but it seems to be breaking some open source builds #1527. Explicitly qualify the calls into those functions to try and fix the build break. Since we cannot conditionally import either of the above (because they are marked as unavailable), we can't rely on the standard implementations. To prevent ADL from kicking in when the standard-library defines these, we fully qualify these and use `tag_invoke` for the customization points used in tests. Reviewed By: davidtgoldblatt Differential Revision: D26742072 fbshipit-source-id: 9f44bbfd37530f5ecffa3e03d673cfb1df953299
Summary: `std::atomic_wait()` and `std::atomic_notify_one()` are marked as unavailable. Not really sure what that means, but it seems to be breaking some open source builds facebook#1527. Explicitly qualify the calls into those functions to try and fix the build break. Since we cannot conditionally import either of the above (because they are marked as unavailable), we can't rely on the standard implementations. To prevent ADL from kicking in when the standard-library defines these, we fully qualify these and use `tag_invoke` for the customization points used in tests. Reviewed By: davidtgoldblatt Differential Revision: D26742072 fbshipit-source-id: 9f44bbfd37530f5ecffa3e03d673cfb1df953299
|
Xcode 12.5 has been released. Is there a workaround for this? I can't build anything right now 😬 Happy to help where I can but don't know my way around the RN codebase particularly well, it's pretty daunting! Edit: If anyone else comes across this, looks like a fix has been pushed but not released yet. Workaround in the meantime - facebook/flipper#2215 (comment) |
|
8477e25 should have fixed this |
|
Manually editing the Flipper-Folly pod file just pushes the compile error onto a subsequent Flipper pod, and does not fix the issue for me :-( When I try to disable Flipper in the podfile, I get this when trying to build the app: So I'm pretty stuck right now, any suggestions massively appreciated as I think a lot of people are in this situation. |
|
The solutions that worked for me was comment out the flipper part on the Podfile use_flipper!({ 'Flipper' => '0.86.0' }) |
|
Now facing this issue, commenting out flipper post install portion does not work for me. Started happening after I upgraded Xcode this morning. |
|
I managed to resolve this by removing flipper altogether. As some suggested to remove the flipper post install hook. This alone did not resolve the issue. For iOS I went ahead and removed every reference to flipper, namely the InitializeFlipper function and it's imports. UPDATE: I did more digging and was able to restore Flipper and get everything to build successfully with this workaround found here #31441 (comment) Back in business. |
|
Can't build on xCode 12.5, why commenting out flipper in pod file doesn't work? |
|
Upstream flipper podspecs should be updated. |
|
This is happening to me. I updated from 0.63.4 to 0.64.1. I don't even have flipper enabled. I think it doesn't have anything to do with flipper.
How about in CI? |
Has that been released? |
Using the latest XCode beta with a React Native app, Folly is failing to build due to an unavailable method being called within
DistributedMutex-inl.h, as shown below.The text was updated successfully, but these errors were encountered: