Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions for new debug hook useDebugValue #7356

Closed
wants to merge 2 commits into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 15, 2019

Add definitions for new debug hook, useDebugValue (facebook/react#14559)

I'm sorry for not updating tests 😦make and yarn install both still failing for me.

cc @jbrown215

@jbrown215
Copy link
Contributor

Happy to re-record again. Thanks for doing these!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrown215 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@nmote nmote added the Library definitions Issues or pull requests about core library definitions label Jan 16, 2019
@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 17, 2019

Updated to include the optional formatter function param!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrown215 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Library definitions Issues or pull requests about core library definitions Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants