You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ah, I totally missed that. Looks like it snuck in in #303. We should probably just fix that so it uses npm again. Or fallback to yarn. Or better, work out if you're using yarn in the caller. There's no reason for it to actually require yarn though.
That said, draft is using yarn for it's dependency manager so if you're working on draft, it should use yarn.
I don't particularly care to call it out for contributing in this project since we're fairly unfriendly to external contributions anyway (really not intended to be good at it). But we shouldn't break people trying to contribute to our projects.
fbjs
assumes in various placesyarn
is installed but doesn't declare it as a dependency or call it out in the README. To name a few:fbjs/package.json
Lines 18 to 22 in af9fefa
fbjs
prepublish script -fbjs/packages/fbjs/package.json
Line 11 in af9fefa
check-dependencies
Gulp plugin -fbjs/packages/fbjs-scripts/gulp/check-dependencies.js
Line 25 in ccad8f1
etc.
I believe it would be useful to call out
fbjs
depends on Facebook's omakase stack in the README at a minimum.The text was updated successfully, but these errors were encountered: