Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __DEV__ & Flow interaction #185

Open
zpao opened this issue Sep 27, 2016 · 0 comments
Open

Fix __DEV__ & Flow interaction #185

zpao opened this issue Sep 27, 2016 · 0 comments

Comments

@zpao
Copy link
Member

zpao commented Sep 27, 2016

Ok, there are a couple pieces to this.

  1. Revert the removal of flow/lib/dev.js from Clean .flowconfig so users won't need configuration to use fbjs #182. We need this for projects consuming fbjs directly & using flow, which will check the raw src files. We probably want it for ourselves too (not currently an issue because the files using __DEV__ are not flowified).
  2. Add an inline declare as part of the Flow transform, inserting declare var __DEV__: boolean; at the top of each file using it.

We can ship 0.8.5 once we have part 1 here done. It's no worse than today (strictly better since the other flow+fbjs issues are resolved). We don't even need part 2 done for fbjs itself (same aside as part 1 above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant