Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Update README.md #11

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Conversation

SandroMachado
Copy link
Contributor

@SandroMachado SandroMachado commented Jul 15, 2016

Fix ` misplaced.

@ghost
Copy link

ghost commented Jul 15, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@nlutsenko
Copy link
Contributor

Hey @SandroMachado, that actually is a correct placement.
The Swift type name for a single permission is either ReadPermission/WritePermission or just Permission, so here we are referencing an array of Permission types, being Permissions 😁

Does it make sense? Or you think it's just too confusing?

@nlutsenko
Copy link
Contributor

Maybe just removing the s in the end would make it clearer?

@SandroMachado
Copy link
Contributor Author

Yup, removing the s makes more sense to me :)

@nlutsenko
Copy link
Contributor

Great, please update the PR, sign the CLA and I'll gladly merge this in!
Congrats on being the first outside contributor!

@SandroMachado
Copy link
Contributor Author

@nlutsenko Thanks. I think I already signed the CLA. Can you please confirm?

@ghost ghost added the CLA Signed The Facebook CLA has been signed label Jul 15, 2016
@nlutsenko
Copy link
Contributor

Yup, ^ that tag above means that it's signed.
Update the PR with removal of s and we are all good to go.

@SandroMachado
Copy link
Contributor Author

Updated. 👍

@ghost ghost added the CLA Signed The Facebook CLA has been signed label Jul 15, 2016
@nlutsenko nlutsenko added this to the 0.1.2 milestone Jul 15, 2016
@nlutsenko nlutsenko merged commit 123f9bb into facebookarchive:master Jul 15, 2016
@dipkasyap dipkasyap mentioned this pull request Aug 27, 2019
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed The Facebook CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants